Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: runtime/bin/socket_linux.cc

Issue 17840009: - Use VOID_TEMP_FAILURE_RETRY where needed (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/bin/socket_android.cc ('k') | runtime/bin/socket_macos.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 #if defined(TARGET_OS_LINUX) 6 #if defined(TARGET_OS_LINUX)
7 7
8 #include <errno.h> // NOLINT 8 #include <errno.h> // NOLINT
9 #include <stdio.h> // NOLINT 9 #include <stdio.h> // NOLINT
10 #include <stdlib.h> // NOLINT 10 #include <stdlib.h> // NOLINT
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 TEMP_FAILURE_RETRY(close(fd)); 321 TEMP_FAILURE_RETRY(close(fd));
322 return -1; 322 return -1;
323 } 323 }
324 324
325 // Test for invalid socket port 65535 (some browsers disallow it). 325 // Test for invalid socket port 65535 (some browsers disallow it).
326 if (port == 0 && Socket::GetPort(fd) == 65535) { 326 if (port == 0 && Socket::GetPort(fd) == 65535) {
327 // Don't close fd until we have created new. By doing that we ensure another 327 // Don't close fd until we have created new. By doing that we ensure another
328 // port. 328 // port.
329 intptr_t new_fd = CreateBindListen(addr, 0, backlog, v6_only); 329 intptr_t new_fd = CreateBindListen(addr, 0, backlog, v6_only);
330 int err = errno; 330 int err = errno;
331 TEMP_FAILURE_RETRY(close(fd)); 331 VOID_TEMP_FAILURE_RETRY(close(fd));
332 errno = err; 332 errno = err;
333 return new_fd; 333 return new_fd;
334 } 334 }
335 335
336 if (TEMP_FAILURE_RETRY(listen(fd, backlog > 0 ? backlog : SOMAXCONN)) != 0) { 336 if (TEMP_FAILURE_RETRY(listen(fd, backlog > 0 ? backlog : SOMAXCONN)) != 0) {
337 TEMP_FAILURE_RETRY(close(fd)); 337 TEMP_FAILURE_RETRY(close(fd));
338 return -1; 338 return -1;
339 } 339 }
340 340
341 Socket::SetNonBlocking(fd); 341 Socket::SetNonBlocking(fd);
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 SOL_TCP, 401 SOL_TCP,
402 TCP_NODELAY, 402 TCP_NODELAY,
403 reinterpret_cast<char *>(&on), 403 reinterpret_cast<char *>(&on),
404 sizeof(on))) == 0; 404 sizeof(on))) == 0;
405 } 405 }
406 406
407 } // namespace bin 407 } // namespace bin
408 } // namespace dart 408 } // namespace dart
409 409
410 #endif // defined(TARGET_OS_LINUX) 410 #endif // defined(TARGET_OS_LINUX)
OLDNEW
« no previous file with comments | « runtime/bin/socket_android.cc ('k') | runtime/bin/socket_macos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698