Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 17840006: Move IndexedDB files out of in_process_webkit (Closed)

Created:
7 years, 6 months ago by jsbell
Modified:
7 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, darin (slow to review), alecflett, dgrogan, jamesr
Visibility:
Public.

Description

Move IndexedDB files out of in_process_webkit The browser-process implementation of IndexedDB was moved off the WebKit thread in r208544; since that change has stuck, move the files to their new home. BUG=234279 R=darin@chromium.org, jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208771

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2119 lines) Patch
D content/browser/in_process_webkit/indexed_db_browsertest.cc View 1 chunk +0 lines, -425 lines 0 comments Download
D content/browser/in_process_webkit/indexed_db_callbacks.h View 1 chunk +0 lines, -210 lines 0 comments Download
D content/browser/in_process_webkit/indexed_db_callbacks.cc View 1 chunk +0 lines, -296 lines 0 comments Download
D content/browser/in_process_webkit/indexed_db_database_callbacks.h View 1 chunk +0 lines, -39 lines 0 comments Download
D content/browser/in_process_webkit/indexed_db_database_callbacks.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D content/browser/in_process_webkit/indexed_db_dispatcher_host.h View 1 chunk +0 lines, -209 lines 0 comments Download
D content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 1 chunk +0 lines, -853 lines 0 comments Download
A + content/browser/indexed_db/indexed_db_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/indexed_db/indexed_db_callbacks.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/indexed_db/indexed_db_callbacks.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 2 chunks +2 lines, -3 lines 2 comments Download
A + content/browser/indexed_db/indexed_db_database_callbacks.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/indexed_db/indexed_db_database_callbacks.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_callbacks_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/indexed_db/indexed_db_dispatcher_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/indexed_db/indexed_db_dispatcher_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 2 chunks +6 lines, -6 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
jsbell
jam@ - can you take a look? https://codereview.chromium.org/17840006/diff/1/content/browser/indexed_db/indexed_db_database.cc File content/browser/indexed_db/indexed_db_database.cc (left): https://codereview.chromium.org/17840006/diff/1/content/browser/indexed_db/indexed_db_database.cc#oldcode1599 content/browser/indexed_db/indexed_db_database.cc:1599: DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::WEBKIT_DEPRECATED)); This ...
7 years, 6 months ago (2013-06-26 17:40:33 UTC) #1
jsbell
CCing a few more people who probably care
7 years, 6 months ago (2013-06-26 18:52:33 UTC) #2
darin (slow to review)
/dance LGTM
7 years, 6 months ago (2013-06-26 19:25:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/17840006/1
7 years, 6 months ago (2013-06-26 19:31:13 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=12548
7 years, 6 months ago (2013-06-26 19:40:25 UTC) #5
jam
lgtm
7 years, 6 months ago (2013-06-26 19:48:55 UTC) #6
jsbell
7 years, 6 months ago (2013-06-26 20:18:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r208771 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698