Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1783973002: Update .gn .isolate files for VS 2015 DLLs (Closed)

Created:
4 years, 9 months ago by brucedawson
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update .gn .isolate files for VS 2015 DLLs Component builds use CRT DLLs and the set of DLLs has changed dramatically for VS 2015. This updates base/BUILD.gn to add the necessary files to the .isolate file, including the Universal Windows 10 CRT files. This is the .gn version of crrev.com/1676943002 BUG=440500 Committed: https://crrev.com/cad78b03905d5d9d4f8c8575aa97606444c28ed5 Cr-Commit-Position: refs/heads/master@{#380479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -4 lines) Patch
M base/BUILD.gn View 2 chunks +59 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-10 21:11:02 UTC) #2
brucedawson
This gets .isolate for .gn builds working for VS 2015. I tested swarming with debug/release ...
4 years, 9 months ago (2016-03-10 21:12:12 UTC) #4
Nico
lgtm2 maybe mention "gn port of https://codereview.chromium.org/1676943002" in the cl description. Sorry about not catching ...
4 years, 9 months ago (2016-03-10 21:34:29 UTC) #5
brucedawson
On 2016/03/10 21:34:29, Nico wrote: > lgtm2 > > > maybe mention "gn port of ...
4 years, 9 months ago (2016-03-10 21:37:28 UTC) #7
Nico
lgtm-2 too
4 years, 9 months ago (2016-03-10 21:39:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783973002/1
4 years, 9 months ago (2016-03-10 21:40:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 22:14:31 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 22:15:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cad78b03905d5d9d4f8c8575aa97606444c28ed5
Cr-Commit-Position: refs/heads/master@{#380479}

Powered by Google App Engine
This is Rietveld 408576698