Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1783933003: Split CPDF_Stream/CPDF_StreamAcc into separate files (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -135 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M core/include/fpdfapi/cpdf_object.h View 1 chunk +8 lines, -0 lines 0 comments Download
M core/include/fpdfapi/cpdf_stream.h View 2 chunks +1 line, -39 lines 0 comments Download
A core/include/fpdfapi/cpdf_stream_acc.h View 1 chunk +46 lines, -0 lines 0 comments Download
M core/include/fpdfapi/fpdf_resource.h View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/cpdf_parser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/cpdf_stream.cpp View 2 chunks +1 line, -96 lines 0 comments Download
A core/src/fpdfapi/fpdf_parser/cpdf_stream_acc.cpp View 1 chunk +107 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_BitStream.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M pdfium.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M xfa/src/fxfa/app/xfa_ffapp.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Dan, for review. Not sure about nesting ...
4 years, 9 months ago (2016-03-10 22:38:54 UTC) #2
dsinclair
lgtm
4 years, 9 months ago (2016-03-15 13:32:12 UTC) #3
Tom Sepez
4 years, 9 months ago (2016-03-15 16:34:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
92bbb6fce88d1cb4d931da66adf690850ce62fd1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698