Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1530)

Issue 1783913003: Moved resolverChanged for mq updates into StyleEngine. (Closed)

Created:
4 years, 9 months ago by rune
Modified:
4 years, 9 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved resolverChanged for mq updates into StyleEngine. The placement of resolverChanged() needs a bit of explanation. We incorrectly only clear the rulesets of active stylesheets when media query evaluation changes. That currently causes crbug.com/589083. Updating the active stylesheets (resolverChanged) before clearing the ruleset will at least make sure that rule set for @media rules inside sheets with a media attribute changing evaluation will be cleared correctly. Moving resolverChanged() would have made the effects of 589083 worse. BUG=567021 Committed: https://crrev.com/da608f1745bd044fa96b58c3e0c9aa7e53eed3dc Cr-Commit-Position: refs/heads/master@{#381921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783913003/1
4 years, 9 months ago (2016-03-11 16:01:03 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-11 18:04:18 UTC) #4
rune
4 years, 9 months ago (2016-03-11 18:19:29 UTC) #6
rune
ptal
4 years, 9 months ago (2016-03-17 12:57:13 UTC) #7
esprehn
lgtm
4 years, 9 months ago (2016-03-18 05:01:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783913003/1
4 years, 9 months ago (2016-03-18 07:10:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 09:45:40 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 09:46:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da608f1745bd044fa96b58c3e0c9aa7e53eed3dc
Cr-Commit-Position: refs/heads/master@{#381921}

Powered by Google App Engine
This is Rietveld 408576698