Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1783883002: Hide/Show the checkmark in the Wallpaper Picker grid when 'Surprise Me' is enabled/disabled. (Closed)

Created:
4 years, 9 months ago by xdai1
Modified:
4 years, 8 months ago
Reviewers:
bshe
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide/Show the checkmark in the Wallpaper Picker grid when 'Surprise Me' is enabled/disabled. Also update the SurpriseMe checkbox's status. Test steps 1: 1. Open the Wallpaper Picker App 2. Enable/Disable the "Surprise Me" checkbox and verify the checkmark/checkbox are updated accordingly. Test steps 2: 1. Open the Wallpaper Picker App on two devices 2. Enable/Disable the "Surprise Me" checkbox on one device and check the checkmark/checkbox are updated on another device accordingly. BUG=593795 Committed: https://crrev.com/41c2ecafe3e33f583e853757a2564fc1dcd5459e Cr-Commit-Position: refs/heads/master@{#385492}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js View 1 1 chunk +18 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
xdai1
Biao, could you help review this CL please? Thanks!
4 years, 9 months ago (2016-03-10 17:51:58 UTC) #2
bshe
On 2016/03/10 17:51:58, xdai1 wrote: > Biao, could you help review this CL please? Thanks! ...
4 years, 9 months ago (2016-03-11 19:17:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783883002/40001
4 years, 8 months ago (2016-04-06 16:41:07 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-04-06 17:24:21 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 17:25:51 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/41c2ecafe3e33f583e853757a2564fc1dcd5459e
Cr-Commit-Position: refs/heads/master@{#385492}

Powered by Google App Engine
This is Rietveld 408576698