Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1783853003: Fix no-i18n builds. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix no-i18n builds. TBR=littledan@chromium.org NOTRY=true Committed: https://crrev.com/efc50493b71af75a62f53d120c578f79d07abcf2 Cr-Commit-Position: refs/heads/master@{#34703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/regexp/regexp-parser.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yang
4 years, 9 months ago (2016-03-11 07:23:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783853003/1
4 years, 9 months ago (2016-03-11 07:24:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 07:26:01 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/efc50493b71af75a62f53d120c578f79d07abcf2 Cr-Commit-Position: refs/heads/master@{#34703}
4 years, 9 months ago (2016-03-11 07:26:54 UTC) #8
Dan Ehrenberg
lgtm
4 years, 9 months ago (2016-03-11 07:29:13 UTC) #9
Dan Ehrenberg
Machenbach@, would it make sense to add a noi18n build to the pre-cq to make ...
4 years, 9 months ago (2016-03-11 07:30:25 UTC) #10
Michael Achenbach
On 2016/03/11 07:30:25, Dan Ehrenberg wrote: > Machenbach@, would it make sense to add a ...
4 years, 9 months ago (2016-03-11 07:37:40 UTC) #11
Yang
4 years, 9 months ago (2016-03-11 07:47:35 UTC) #12
Message was sent while issue was closed.
On 2016/03/11 07:37:40, Michael Achenbach wrote:
> On 2016/03/11 07:30:25, Dan Ehrenberg wrote:
> > Machenbach@, would it make sense to add a noi18n build to the pre-cq to make
> > these issues easier to come across ahead of time?
> 
> Please file a bug. Principally no problem. Though, this was the first no-i18n
> compile breakage that made it through in the last year I think.

I don't think we need this just yet. Maybe if this happens one or two more
times.

Powered by Google App Engine
This is Rietveld 408576698