[chrome.displaySource][WiFi Display] Video formats capability negotiation

[chrome.displaySource][WiFi Display] Video formats capability negotiation

This patch is implementing video formats capability negotiation
based on the given MediaStreamTrack object: finds the video format
having the same frame size and frame rate as the given MediaStreamTrack
among the ones supported by sink device.

BUG=242107
Committed: https://crrev.com/2ba81b5fd3b9584c8839b0478242ea0b9adb57b8
Cr-Commit-Position: refs/heads/master@{#381692}

[Mikhail, 2016-03-10 16:33:47]

Description was changed from

==========
[chrome.displaySource][WiFi Display] Video formats capability negotiation

This patch is implementing video formats capability negotiation
based on the given MediaStreamTrack object: finds the video format
having the same frame size and frame rate as the given MediaStreamTrack
among the ones supported by sink device.

BUG=242107
==========

to

==========
[chrome.displaySource][WiFi Display] Video formats capability negotiation

This patch is implementing video formats capability negotiation
based on the given MediaStreamTrack object: finds the video format
having the same frame size and frame rate as the given MediaStreamTrack
among the ones supported by sink device.

BUG=242107
==========

[Mikhail, 2016-03-10 16:33:47]

mikhail.pozdnyakov@intel.com changed reviewers:
+ alexander.shalamov@intel.com, asargent@chromium.org, esprehn@chromium.org,
jochen@chromium.org

[Mikhail, 2016-03-10 16:39:09]

PTAL
Unfortunately I had to add a dep from 'extensions/renderer/' to
'content/renderer/' in order to get content::MediaStreamVideoSource.
Alternatively, a new content API could be introduced but I need an advice on
that. Thanks

[shalamov, 2016-03-11 12:06:59]

lgtm for WiFi Display specific changes (cap negotiations).

[jochen (gone - plz use gerrit), 2016-03-11 14:28:29]

please introduce a content/public API

[Mikhail, 2016-03-11 21:19:11]

On 2016/03/11 14:28:29, jochen wrote:
> please introduce a content/public API

done at https://codereview.chromium.org/1672713002/

[jochen (gone - plz use gerrit), 2016-03-14 14:21:25]

I'm only an owner of extensions/renderer for v8 related stuff - for non-v8
changes, please add a regular extension owner

[Mikhail, 2016-03-14 17:31:41]

@Antony, could you please have a look?

[asargent_no_longer_on_chrome, 2016-03-16 21:29:57]

lgtm

https://codereview.chromium.org/1783843002/diff/40001/extensions/renderer/api...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_media_manager.cc
(right):

https://codereview.chromium.org/1783843002/diff/40001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_media_manager.cc:54:
unsigned session_type = 0;
Should this be an explicitly sized type like uint32_t or something (our style
guide generally requires this, except for code that has to interoperate with
third party code)? Or does it need to be plain "unsigned" because of the wds
library?

[esprehn, 2016-03-16 22:07:37]

I don't think I'm the right reviewer for this.

[esprehn, 2016-03-16 22:07:43]

esprehn@chromium.org changed reviewers:
- esprehn@chromium.org

[Mikhail, 2016-03-17 11:26:24]

On 2016/03/16 21:29:57, Antony Sargent wrote:
>
https://codereview.chromium.org/1783843002/diff/40001/extensions/renderer/api...
>
extensions/renderer/api/display_source/wifi_display/wifi_display_media_manager.cc:54:
> unsigned session_type = 0;
> Should this be an explicitly sized type like uint32_t or something (our style
> guide generally requires this, except for code that has to interoperate with
> third party code)? Or does it need to be plain "unsigned" because of the wds
> library?

switched to uint16_t

[Mikhail, 2016-03-17 11:26:59]

The CQ bit was checked by mikhail.pozdnyakov@intel.com

[Mikhail, 2016-03-17 11:26:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
alexander.shalamov@intel.com, asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1783843002/#ps60001
(title: "Style fixes")

[commit-bot: I haz the power, 2016-03-17 11:27:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783843002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783843002/60001

[commit-bot: I haz the power, 2016-03-17 11:56:02]

Description was changed from

==========
[chrome.displaySource][WiFi Display] Video formats capability negotiation

This patch is implementing video formats capability negotiation
based on the given MediaStreamTrack object: finds the video format
having the same frame size and frame rate as the given MediaStreamTrack
among the ones supported by sink device.

BUG=242107
==========

to

==========
[chrome.displaySource][WiFi Display] Video formats capability negotiation

This patch is implementing video formats capability negotiation
based on the given MediaStreamTrack object: finds the video format
having the same frame size and frame rate as the given MediaStreamTrack
among the ones supported by sink device.

BUG=242107
==========

[commit-bot: I haz the power, 2016-03-17 11:56:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-17 11:57:03]

Description was changed from

==========
[chrome.displaySource][WiFi Display] Video formats capability negotiation

This patch is implementing video formats capability negotiation
based on the given MediaStreamTrack object: finds the video format
having the same frame size and frame rate as the given MediaStreamTrack
among the ones supported by sink device.

BUG=242107
==========

to

==========
[chrome.displaySource][WiFi Display] Video formats capability negotiation

This patch is implementing video formats capability negotiation
based on the given MediaStreamTrack object: finds the video format
having the same frame size and frame rate as the given MediaStreamTrack
among the ones supported by sink device.

BUG=242107

Committed: https://crrev.com/2ba81b5fd3b9584c8839b0478242ea0b9adb57b8
Cr-Commit-Position: refs/heads/master@{#381692}
==========

[commit-bot: I haz the power, 2016-03-17 11:57:04]

Patchset 4 (id:??) landed as
https://crrev.com/2ba81b5fd3b9584c8839b0478242ea0b9adb57b8
Cr-Commit-Position: refs/heads/master@{#381692}