Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 178383003: Split picture version into min & max supported versions (Closed)

Created:
6 years, 10 months ago by robertphillips
Modified:
6 years, 10 months ago
Reviewers:
bsalomon, mtklein, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This is intended to make it easier for us to be backwards compatible. Committed: http://code.google.com/p/skia/source/detail?r=13575

Patch Set 1 #

Total comments: 2

Patch Set 2 : renamed MAX_PICTURE_VERSION to CURRENT_PICTURE_VERSION #

Patch Set 3 : fixed comment #

Total comments: 3

Patch Set 4 : Set min picture version to 19 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M include/core/SkPicture.h View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M src/core/SkPicture.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
robertphillips
6 years, 10 months ago (2014-02-24 19:51:26 UTC) #1
bsalomon
https://codereview.chromium.org/178383003/diff/1/include/core/SkPicture.h File include/core/SkPicture.h (right): https://codereview.chromium.org/178383003/diff/1/include/core/SkPicture.h#newcode248 include/core/SkPicture.h:248: static const uint32_t MAX_PICTURE_VERSION = 20; // the current ...
6 years, 10 months ago (2014-02-24 19:52:49 UTC) #2
robertphillips
https://codereview.chromium.org/178383003/diff/1/include/core/SkPicture.h File include/core/SkPicture.h (right): https://codereview.chromium.org/178383003/diff/1/include/core/SkPicture.h#newcode248 include/core/SkPicture.h:248: static const uint32_t MAX_PICTURE_VERSION = 20; // the current ...
6 years, 10 months ago (2014-02-24 19:56:13 UTC) #3
mtklein
https://codereview.chromium.org/178383003/diff/80001/include/core/SkPicture.h File include/core/SkPicture.h (right): https://codereview.chromium.org/178383003/diff/80001/include/core/SkPicture.h#newcode247 include/core/SkPicture.h:247: static const uint32_t MIN_PICTURE_VERSION = 20; Just curious: we ...
6 years, 10 months ago (2014-02-24 19:58:37 UTC) #4
robertphillips
https://codereview.chromium.org/178383003/diff/80001/include/core/SkPicture.h File include/core/SkPicture.h (right): https://codereview.chromium.org/178383003/diff/80001/include/core/SkPicture.h#newcode247 include/core/SkPicture.h:247: static const uint32_t MIN_PICTURE_VERSION = 20; I suspect it ...
6 years, 10 months ago (2014-02-24 20:05:48 UTC) #5
robertphillips
https://codereview.chromium.org/178383003/diff/80001/include/core/SkPicture.h File include/core/SkPicture.h (right): https://codereview.chromium.org/178383003/diff/80001/include/core/SkPicture.h#newcode247 include/core/SkPicture.h:247: static const uint32_t MIN_PICTURE_VERSION = 20; Chatted with Alexis ...
6 years, 10 months ago (2014-02-24 20:13:19 UTC) #6
reed1
lgtm but don't take my word for it...
6 years, 10 months ago (2014-02-24 21:00:35 UTC) #7
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 10 months ago (2014-02-25 02:02:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/178383003/130001
6 years, 10 months ago (2014-02-25 02:02:42 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 02:16:12 UTC) #10
Message was sent while issue was closed. 
Change committed as 13575

Powered by Google App Engine
This is Rietveld 408576698