Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issue 1783813003: openjpeg: Don't build with SSE instrinsics for 32-bit x86. (Closed)

Created:
4 years, 9 months ago by Oliver Chang
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

openjpeg: Don't build with SSE instrinsics for 32-bit x86. Fixes 32-bit clang-cl build. These intrinsics require addresses with 16-byte alignment, which doesn't cause issues for 64-bit builds because of allocator alignment. MSVC doesn't recognise the __SSE__, __SSE2__ defines, which is why this problem never surfaced before. R=tsepez@chromium.org BUG=pdfium:433 Committed: https://pdfium.googlesource.com/pdfium/+/2852ce07c4e5b1053420cbf375e098e09faf679c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -7 lines) Patch
A third_party/libopenjpeg20/0012-mct_sse.patch View 1 chunk +60 lines, -0 lines 0 comments Download
M third_party/libopenjpeg20/README.pdfium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libopenjpeg20/mct.c View 5 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Oliver Chang
Tom, for review.
4 years, 9 months ago (2016-03-10 18:59:14 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-10 19:03:17 UTC) #3
Oliver Chang
4 years, 9 months ago (2016-03-10 19:06:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2852ce07c4e5b1053420cbf375e098e09faf679c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698