Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: net/cookies/canonical_cookie_unittest.cc

Issue 1783813002: SameSite: Strict/Lax behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@strict-lax
Patch Set: Moar. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cookies/canonical_cookie_unittest.cc
diff --git a/net/cookies/canonical_cookie_unittest.cc b/net/cookies/canonical_cookie_unittest.cc
index 11a20df890023b7c8d5ff955c6c97c162e46768f..b213e82a220343a6ba458061dda32b3987ff54c9 100644
--- a/net/cookies/canonical_cookie_unittest.cc
+++ b/net/cookies/canonical_cookie_unittest.cc
@@ -85,7 +85,8 @@ TEST(CanonicalCookieTest, Create) {
// Test creating SameSite cookies.
CookieOptions same_site_options;
- same_site_options.set_include_same_site();
+ same_site_options.set_same_site_mode(
+ CookieOptions::SameSiteMode::INCLUDE_STRICT_AND_LAX);
cookie = CanonicalCookie::Create(url, "A=2; SameSite=Strict", creation_time,
same_site_options);
EXPECT_TRUE(cookie.get());
@@ -470,7 +471,8 @@ TEST(CanonicalCookieTest, IncludeSameSiteForSameSiteURL) {
EXPECT_FALSE(cookie->IncludeForRequestURL(secure_url, options));
// Same-site cookies are included for same-site requests:
- options.set_include_same_site();
+ options.set_same_site_mode(
+ CookieOptions::SameSiteMode::INCLUDE_STRICT_AND_LAX);
cookie = CanonicalCookie::Create(secure_url, "A=2; SameSite=Strict",
creation_time, options);
EXPECT_EQ(CookieSameSite::STRICT_MODE, cookie->SameSite());

Powered by Google App Engine
This is Rietveld 408576698