Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: content/browser/frame_host/render_frame_message_filter.cc

Issue 1783813002: SameSite: Strict/Lax behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@strict-lax
Patch Set: Moar. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_message_filter.cc
diff --git a/content/browser/frame_host/render_frame_message_filter.cc b/content/browser/frame_host/render_frame_message_filter.cc
index 803ce426f4fd58617fe21657165e315d13ca83b6..b715d61c4f8006757eea7242391bf1eb1da5549e 100644
--- a/content/browser/frame_host/render_frame_message_filter.cc
+++ b/content/browser/frame_host/render_frame_message_filter.cc
@@ -394,7 +394,8 @@ void RenderFrameMessageFilter::OnGetCookies(int render_frame_id,
net::URLRequestContext* context = GetRequestContextForURL(url);
net::CookieOptions options;
- options.set_include_same_site();
+ options.set_same_site_mode(
+ net::CookieOptions::SameSiteMode::INCLUDE_STRICT_AND_LAX);
mmenke 2016/03/17 19:15:56 Is this right? Seems like for an iframe with an o
Mike West 2016/03/17 19:57:11 Hrm. I think you're right, which is unfortunate, a
Mike West 2016/03/18 14:27:17 Done, and added a browser test to cover.
context->cookie_store()->GetCookieListWithOptionsAsync(
url, options,
base::Bind(&RenderFrameMessageFilter::CheckPolicyForCookies, this,

Powered by Google App Engine
This is Rietveld 408576698