Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: net/cookies/canonical_cookie_unittest.cc

Issue 1783813002: SameSite: Strict/Lax behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@strict-lax
Patch Set: WIP. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cookies/canonical_cookie.h" 5 #include "net/cookies/canonical_cookie.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/test/histogram_tester.h" 8 #include "base/test/histogram_tester.h"
9 #include "net/cookies/cookie_constants.h" 9 #include "net/cookies/cookie_constants.h"
10 #include "net/cookies/cookie_options.h" 10 #include "net/cookies/cookie_options.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 CanonicalCookie::Create(url, "A=2; HttpOnly", creation_time, options); 78 CanonicalCookie::Create(url, "A=2; HttpOnly", creation_time, options);
79 EXPECT_FALSE(cookie.get()); 79 EXPECT_FALSE(cookie.get());
80 CookieOptions httponly_options; 80 CookieOptions httponly_options;
81 httponly_options.set_include_httponly(); 81 httponly_options.set_include_httponly();
82 cookie = CanonicalCookie::Create(url, "A=2; HttpOnly", creation_time, 82 cookie = CanonicalCookie::Create(url, "A=2; HttpOnly", creation_time,
83 httponly_options); 83 httponly_options);
84 EXPECT_TRUE(cookie->IsHttpOnly()); 84 EXPECT_TRUE(cookie->IsHttpOnly());
85 85
86 // Test creating http only cookies. 86 // Test creating http only cookies.
87 CookieOptions same_site_options; 87 CookieOptions same_site_options;
88 same_site_options.set_include_same_site(); 88 same_site_options.set_include_same_site(CookieSameSite::STRICT_MODE);
89 cookie = CanonicalCookie::Create(url, "A=2; SameSite=Strict", creation_time, 89 cookie = CanonicalCookie::Create(url, "A=2; SameSite=Strict", creation_time,
90 same_site_options); 90 same_site_options);
91 EXPECT_TRUE(cookie.get()); 91 EXPECT_TRUE(cookie.get());
92 EXPECT_EQ(CookieSameSite::STRICT_MODE, cookie->SameSite()); 92 EXPECT_EQ(CookieSameSite::STRICT_MODE, cookie->SameSite());
93 93
94 // Test the creating cookies using specific parameter instead of a cookie 94 // Test the creating cookies using specific parameter instead of a cookie
95 // string. 95 // string.
96 cookie = CanonicalCookie::Create(url, "A", "2", "www.example.com", "/test", 96 cookie = CanonicalCookie::Create(url, "A", "2", "www.example.com", "/test",
97 creation_time, base::Time(), false, false, 97 creation_time, base::Time(), false, false,
98 CookieSameSite::DEFAULT_MODE, false, 98 CookieSameSite::DEFAULT_MODE, false,
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
455 creation_time, options); 455 creation_time, options);
456 EXPECT_EQ(CookieSameSite::STRICT_MODE, cookie->SameSite()); 456 EXPECT_EQ(CookieSameSite::STRICT_MODE, cookie->SameSite());
457 EXPECT_FALSE(cookie->IncludeForRequestURL(secure_url, options)); 457 EXPECT_FALSE(cookie->IncludeForRequestURL(secure_url, options));
458 cookie = CanonicalCookie::Create(secure_url_with_path, 458 cookie = CanonicalCookie::Create(secure_url_with_path,
459 "A=2; SameSite=Strict; path=/foo/bar", 459 "A=2; SameSite=Strict; path=/foo/bar",
460 creation_time, options); 460 creation_time, options);
461 EXPECT_EQ(CookieSameSite::STRICT_MODE, cookie->SameSite()); 461 EXPECT_EQ(CookieSameSite::STRICT_MODE, cookie->SameSite());
462 EXPECT_FALSE(cookie->IncludeForRequestURL(secure_url, options)); 462 EXPECT_FALSE(cookie->IncludeForRequestURL(secure_url, options));
463 463
464 // Same-site cookies are included for same-site requests: 464 // Same-site cookies are included for same-site requests:
465 options.set_include_same_site(); 465 options.set_include_same_site(CookieSameSite::STRICT_MODE);
466 cookie = CanonicalCookie::Create(secure_url, "A=2; SameSite=Strict", 466 cookie = CanonicalCookie::Create(secure_url, "A=2; SameSite=Strict",
467 creation_time, options); 467 creation_time, options);
468 EXPECT_EQ(CookieSameSite::STRICT_MODE, cookie->SameSite()); 468 EXPECT_EQ(CookieSameSite::STRICT_MODE, cookie->SameSite());
469 EXPECT_TRUE(cookie->IncludeForRequestURL(secure_url, options)); 469 EXPECT_TRUE(cookie->IncludeForRequestURL(secure_url, options));
470 cookie = CanonicalCookie::Create(secure_url, "A=2; Secure; SameSite=Strict", 470 cookie = CanonicalCookie::Create(secure_url, "A=2; Secure; SameSite=Strict",
471 creation_time, options); 471 creation_time, options);
472 EXPECT_EQ(CookieSameSite::STRICT_MODE, cookie->SameSite()); 472 EXPECT_EQ(CookieSameSite::STRICT_MODE, cookie->SameSite());
473 EXPECT_TRUE(cookie->IncludeForRequestURL(secure_url, options)); 473 EXPECT_TRUE(cookie->IncludeForRequestURL(secure_url, options));
474 cookie = CanonicalCookie::Create(secure_url_with_path, 474 cookie = CanonicalCookie::Create(secure_url_with_path,
475 "A=2; SameSite=Strict; path=/foo/bar", 475 "A=2; SameSite=Strict; path=/foo/bar",
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
704 CanonicalCookie::COOKIE_PREFIX_SECURE, 1); 704 CanonicalCookie::COOKIE_PREFIX_SECURE, 1);
705 EXPECT_TRUE(CanonicalCookie::Create(https_url, "__SecureA=B; Path=/; Secure", 705 EXPECT_TRUE(CanonicalCookie::Create(https_url, "__SecureA=B; Path=/; Secure",
706 creation_time, options)); 706 creation_time, options));
707 histograms.ExpectBucketCount(kCookiePrefixHistogram, 707 histograms.ExpectBucketCount(kCookiePrefixHistogram,
708 CanonicalCookie::COOKIE_PREFIX_SECURE, 2); 708 CanonicalCookie::COOKIE_PREFIX_SECURE, 2);
709 histograms.ExpectBucketCount(kCookiePrefixBlockedHistogram, 709 histograms.ExpectBucketCount(kCookiePrefixBlockedHistogram,
710 CanonicalCookie::COOKIE_PREFIX_SECURE, 1); 710 CanonicalCookie::COOKIE_PREFIX_SECURE, 1);
711 } 711 }
712 712
713 } // namespace net 713 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698