[testing] Extend interpreter testing to message suite.

[testing] Extend interpreter testing to message suite.

This also runs the message test suite against Ignition. By now most of
the source positions (and exception messages) are accurate, the failing
ones have been blacklisted.

R=machenbach@chromium.org

Committed: https://crrev.com/28634e574e867b90dc94a35400f4d497f5b8746e
Cr-Commit-Position: refs/heads/master@{#34708}

[Michael Starzinger, 2016-03-10 15:07:46]

mstarzinger@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Michael Starzinger, 2016-03-10 15:07:47]

Michael: PTAL at the test harness changes.
Ross: FYI about extended test coverage.

[Michael Starzinger, 2016-03-10 15:08:52]

https://codereview.chromium.org/1783773003/diff/1/test/message/message.status
File test/message/message.status (right):

https://codereview.chromium.org/1783773003/diff/1/test/message/message.status...
test/message/message.status:35: 'default-parameter-tdz': [SKIP],
Note that for some reason "FAIL" doesn't do the trick here, so I went with
"SKIP" instead, which works. I plan to fix those soon-ish, so for me it's
acceptable as is.

[rmcilroy, 2016-03-10 15:14:59]

+Mythri FYI since you were planning on look at adding these tests.

LGTM, thanks.

[Michael Starzinger, 2016-03-10 17:36:58]

+Yang, Daniel: FYI, since you are also working on source positions in one way or
the other. :)

[Michael Starzinger, 2016-03-10 18:41:51]

Description was changed from

==========
[testing] Extends Ignition testing to message suite.

This also runs the message test suite against ignition. By now most of
the source positions (and exception messages) are accurate, the failing
ones have been blacklisted.

R=machenbach@chromium.org
==========

to

==========
[testing] Extend Ignition testing to message suite.

This also runs the message test suite against ignition. By now most of
the source positions (and exception messages) are accurate, the failing
ones have been blacklisted.

R=machenbach@chromium.org
==========

[Michael Starzinger, 2016-03-10 18:46:17]

Description was changed from

==========
[testing] Extend Ignition testing to message suite.

This also runs the message test suite against ignition. By now most of
the source positions (and exception messages) are accurate, the failing
ones have been blacklisted.

R=machenbach@chromium.org
==========

to

==========
[testing] Extend interpreter testing to message suite.

This also runs the message test suite against Ignition. By now most of
the source positions (and exception messages) are accurate, the failing
ones have been blacklisted.

R=machenbach@chromium.org
==========

[Michael Achenbach, 2016-03-11 08:00:54]

lgtm

[Yang, 2016-03-11 08:12:11]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-03-11 08:12:12]

https://codereview.chromium.org/1783773003/diff/20001/test/message/message.st...
File test/message/message.status (right):

https://codereview.chromium.org/1783773003/diff/20001/test/message/message.st...
test/message/message.status:35: 'default-parameter-tdz': [SKIP],
Can you mark these as FAIL so that we can figure out when they are fixed? That
way we can remove the failing expectation and prevent the already fixed test to
regress again.

[Yang, 2016-03-11 08:14:03]

On 2016/03/11 08:12:12, Yang wrote:
>
https://codereview.chromium.org/1783773003/diff/20001/test/message/message.st...
> File test/message/message.status (right):
> 
>
https://codereview.chromium.org/1783773003/diff/20001/test/message/message.st...
> test/message/message.status:35: 'default-parameter-tdz': [SKIP],
> Can you mark these as FAIL so that we can figure out when they are fixed? That
> way we can remove the failing expectation and prevent the already fixed test
to
> regress again.

As discussed offline, I overlooked your comment. Never mind.

[Michael Starzinger, 2016-03-11 08:41:40]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-03-11 08:41:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1783773003/#ps20001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-03-11 08:41:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783773003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783773003/20001

[commit-bot: I haz the power, 2016-03-11 08:45:24]

Description was changed from

==========
[testing] Extend interpreter testing to message suite.

This also runs the message test suite against Ignition. By now most of
the source positions (and exception messages) are accurate, the failing
ones have been blacklisted.

R=machenbach@chromium.org
==========

to

==========
[testing] Extend interpreter testing to message suite.

This also runs the message test suite against Ignition. By now most of
the source positions (and exception messages) are accurate, the failing
ones have been blacklisted.

R=machenbach@chromium.org
==========

[commit-bot: I haz the power, 2016-03-11 08:45:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-11 08:46:44]

Description was changed from

==========
[testing] Extend interpreter testing to message suite.

This also runs the message test suite against Ignition. By now most of
the source positions (and exception messages) are accurate, the failing
ones have been blacklisted.

R=machenbach@chromium.org
==========

to

==========
[testing] Extend interpreter testing to message suite.

This also runs the message test suite against Ignition. By now most of
the source positions (and exception messages) are accurate, the failing
ones have been blacklisted.

R=machenbach@chromium.org

Committed: https://crrev.com/28634e574e867b90dc94a35400f4d497f5b8746e
Cr-Commit-Position: refs/heads/master@{#34708}
==========

[commit-bot: I haz the power, 2016-03-11 08:46:45]

Patchset 2 (id:??) landed as
https://crrev.com/28634e574e867b90dc94a35400f4d497f5b8746e
Cr-Commit-Position: refs/heads/master@{#34708}