Issue 1783713003: Add a boolean use_stateless_rejects_if_peer_supported argument to the QuicCryptoServerStream constr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1783713003: Add a boolean use_stateless_rejects_if_peer_supported argument to the QuicCryptoServerStream constr… (Closed)

Created:
4 years, 9 months ago by rjshade

Modified:
4 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add a boolean use_stateless_rejects_if_peer_supported argument to the QuicCryptoServerStream constructor instead of consulting FLAG_enable_quic_stateless_reject_support directly. No behavior change expected. Merge internal change: 115844136 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -9 lines)			Patch
M	net/quic/quic_crypto_server_stream.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	net/quic/quic_crypto_server_stream.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	net/quic/test_tools/quic_test_utils.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/tools/quic/quic_dispatcher_test.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_server_session_base_test.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_simple_server_session.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/tools/quic/quic_simple_server_session_test.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Dependent Patchsets:

Issue 1777293002 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ryan Hamilton

4 years, 9 months ago (2016-03-10 18:09:00 UTC) #2

lgtm, but please fix the name of the flag in the CL description (and in that of
the final CL).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages