Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1783713002: X87: Rework CallApi*Stubs. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Rework CallApi*Stubs. port 5096492f1b0460b2644c7f79f9ccc5881fc65c50 (r34627) original commit message: - Eliminate stubs with a variable number of arguments. (That only worked due to their very limited use. These stubs' interface descriptors were basically lying about their number of args, which will fail when used generically.) - Fix all CallApi*Stubs' interface descriptors to no longer lie about their arguments. - Unify CallApi*Stub, for * in Function, Accessor, FunctionWithFixedArgs. (Since these are now all doing the same thing.) - Rename the unified stub (and interface descriptors) to *ApiCallback*, since that's really what they're doing. - Refuse inlining an API callback if its number of parameters exceeds the supported number of args. BUG= Committed: https://crrev.com/ebd28ac6507f5a828ad20d8fc5b907180bf21685 Cr-Commit-Position: refs/heads/master@{#34652}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-10 02:50:05 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-10 03:53:25 UTC) #3
Weiliang
lgtm lgtm
4 years, 9 months ago (2016-03-10 03:53:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783713002/1
4 years, 9 months ago (2016-03-10 06:15:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 06:30:57 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 06:31:07 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebd28ac6507f5a828ad20d8fc5b907180bf21685
Cr-Commit-Position: refs/heads/master@{#34652}

Powered by Google App Engine
This is Rietveld 408576698