Add a command-line switch to disable in-process stack traces

Add a command-line switch to disable in-process stack traces

In-process stack traces are disrupting crash reporting for
non-sandboxed child processes for Chromecast. On Chromecast devices, all binaries are stripped, so the in-process stack traces are not very useful (and they prevent core dumps and crash reporting from working).

We want to disable in-process stack traces for all builds (even those built locally by developers, or those built for integration tests) so that we can use the core dumps and crash reports for debugging crashes on devices. Therefore, just setting OFFICIAL_BUILD (which should only apply to builds given to users) is not the solution. Instead, add a command-line switch.

BUG=

Committed: https://crrev.com/d104a43445b8a66214d0a3153ed11dc2b3375967
Cr-Commit-Position: refs/heads/master@{#381135}

[kmackay, 2016-03-10 19:24:55]

kmackay@chromium.org changed reviewers:
+ jam@chromium.org, slan@chromium.org

[jam, 2016-03-14 16:17:37]

can you provide more background?

is this happening for local dev builds or for users? If the latter, are you
setting OFFICIAL_BUILD for the shipped builds? (it should be set).

[kmackay, 2016-03-14 16:46:19]

On 2016/03/14 16:17:37, jam wrote:
> can you provide more background?
> 
> is this happening for local dev builds or for users? If the latter, are you
> setting OFFICIAL_BUILD for the shipped builds? (it should be set).

It happens for both eng and user builds. We don't ever set OFFICIAL_BUILD for
Chromecast builds as far as I know.

[kmackay, 2016-03-14 17:39:11]

On 2016/03/14 16:46:19, kmackay wrote:
> On 2016/03/14 16:17:37, jam wrote:
> > can you provide more background?
> > 
> > is this happening for local dev builds or for users? If the latter, are you
> > setting OFFICIAL_BUILD for the shipped builds? (it should be set).
> 
> It happens for both eng and user builds. We don't ever set OFFICIAL_BUILD for
> Chromecast builds as far as I know.

We would like crash reporting to work for all of our builds (both dev builds and
user builds), and I don't think we should be setting OFFICIAL_BUILD for dev
builds (as I understand it). The in-process stack tracing is not very useful to
us, since all code running on the devices is stripped anyway.

[jam, 2016-03-14 18:25:27]

On 2016/03/14 17:39:11, kmackay wrote:
> On 2016/03/14 16:46:19, kmackay wrote:
> > On 2016/03/14 16:17:37, jam wrote:
> > > can you provide more background?
> > > 
> > > is this happening for local dev builds or for users? If the latter, are
you
> > > setting OFFICIAL_BUILD for the shipped builds? (it should be set).
> > 
> > It happens for both eng and user builds. We don't ever set OFFICIAL_BUILD
for
> > Chromecast builds as far as I know.
> 
> We would like crash reporting to work for all of our builds (both dev builds
and
> user builds),

oh really? When you say "dev", do you mean dev channel or developer builds?

For non-chromecast, we don't send crash reports from developer builds because
there could be many bugs there and so it doesn't make sense for someone to look
at them (and also the code isn't even available).

For builds sent to users, OFFICIAL_BUILD should be set. Can you please double
check? There are things, like this, that effect security and so we operate under
the assumption that OFFICIAL_BUILD is always set for builds that go out to
users. If this isn't happening, can you file a bug and cc me to change this?

> and I don't think we should be setting OFFICIAL_BUILD for dev
> builds (as I understand it). The in-process stack tracing is not very useful
to
> us, since all code running on the devices is stripped anyway.

[kmackay, 2016-03-14 18:35:27]

On 2016/03/14 18:25:27, jam wrote:
> oh really? When you say "dev", do you mean dev channel or developer builds?

I mean, internal developer builds. Basically we want crash reporting to be
enabled (and in-process stack tracing to be disabled) for every build, for all
processes.

> 
> For non-chromecast, we don't send crash reports from developer builds because
> there could be many bugs there and so it doesn't make sense for someone to
look
> at them (and also the code isn't even available).
> 
> For builds sent to users, OFFICIAL_BUILD should be set. Can you please double
> check? There are things, like this, that effect security and so we operate
under
> the assumption that OFFICIAL_BUILD is always set for builds that go out to
> users. If this isn't happening, can you file a bug and cc me to change this?

crbug.com/594632

[jam, 2016-03-14 23:16:20]

lgtm

[kmackay, 2016-03-14 23:22:43]

Description was changed from

==========
Add a command-line switch to disable in-process stack traces

In-process stack traces are disrupting crash reporting for
non-sandboxed child processes for Chromecast.

BUG=
==========

to

==========
Add a command-line switch to disable in-process stack traces

In-process stack traces are disrupting crash reporting for
non-sandboxed child processes for Chromecast. On Chromecast devices, all
binaries are stripped, so the in-process stack traces are not very useful (and
they prevent core dumps and crash reporting from working).

We want to disable in-process stack traces for all builds (even those built
locally by developers, or those built for integration tests) so that we can use
the core dumps and crash reports for debugging crashes on devices. Therefore,
just setting OFFICIAL_BUILD (which should only apply to builds given to users)
is not the solution. Instead, add a command-line switch.

BUG=
==========

[kmackay, 2016-03-14 23:22:48]

The CQ bit was checked by kmackay@chromium.org

[commit-bot: I haz the power, 2016-03-14 23:23:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783693004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783693004/1

[commit-bot: I haz the power, 2016-03-15 00:33:54]

Description was changed from

==========
Add a command-line switch to disable in-process stack traces

In-process stack traces are disrupting crash reporting for
non-sandboxed child processes for Chromecast. On Chromecast devices, all
binaries are stripped, so the in-process stack traces are not very useful (and
they prevent core dumps and crash reporting from working).

We want to disable in-process stack traces for all builds (even those built
locally by developers, or those built for integration tests) so that we can use
the core dumps and crash reports for debugging crashes on devices. Therefore,
just setting OFFICIAL_BUILD (which should only apply to builds given to users)
is not the solution. Instead, add a command-line switch.

BUG=
==========

to

==========
Add a command-line switch to disable in-process stack traces

In-process stack traces are disrupting crash reporting for
non-sandboxed child processes for Chromecast. On Chromecast devices, all
binaries are stripped, so the in-process stack traces are not very useful (and
they prevent core dumps and crash reporting from working).

We want to disable in-process stack traces for all builds (even those built
locally by developers, or those built for integration tests) so that we can use
the core dumps and crash reports for debugging crashes on devices. Therefore,
just setting OFFICIAL_BUILD (which should only apply to builds given to users)
is not the solution. Instead, add a command-line switch.

BUG=
==========

[commit-bot: I haz the power, 2016-03-15 00:33:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-15 00:37:05]

Description was changed from

==========
Add a command-line switch to disable in-process stack traces

In-process stack traces are disrupting crash reporting for
non-sandboxed child processes for Chromecast. On Chromecast devices, all
binaries are stripped, so the in-process stack traces are not very useful (and
they prevent core dumps and crash reporting from working).

We want to disable in-process stack traces for all builds (even those built
locally by developers, or those built for integration tests) so that we can use
the core dumps and crash reports for debugging crashes on devices. Therefore,
just setting OFFICIAL_BUILD (which should only apply to builds given to users)
is not the solution. Instead, add a command-line switch.

BUG=
==========

to

==========
Add a command-line switch to disable in-process stack traces

In-process stack traces are disrupting crash reporting for
non-sandboxed child processes for Chromecast. On Chromecast devices, all
binaries are stripped, so the in-process stack traces are not very useful (and
they prevent core dumps and crash reporting from working).

We want to disable in-process stack traces for all builds (even those built
locally by developers, or those built for integration tests) so that we can use
the core dumps and crash reports for debugging crashes on devices. Therefore,
just setting OFFICIAL_BUILD (which should only apply to builds given to users)
is not the solution. Instead, add a command-line switch.

BUG=

Committed: https://crrev.com/d104a43445b8a66214d0a3153ed11dc2b3375967
Cr-Commit-Position: refs/heads/master@{#381135}
==========

[commit-bot: I haz the power, 2016-03-15 00:37:06]

Patchset 1 (id:??) landed as
https://crrev.com/d104a43445b8a66214d0a3153ed11dc2b3375967
Cr-Commit-Position: refs/heads/master@{#381135}