Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1783693002: Ship Node.rootNode (Closed)

Created:
4 years, 9 months ago by yuzuchan
Modified:
4 years, 9 months ago
Reviewers:
tkent, hayato, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship Node.rootNode This CL ships Node.rootNode independently from other ShadowDOM features, in response to requests from web developers. LGTM-ed on this thread : https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/LpXX7Svx8IY BUG=531990 Committed: https://crrev.com/9ca99ec409a1d6f7baf6dd3cd6929e81c967cac1 Cr-Commit-Position: refs/heads/master@{#380363}

Patch Set 1 #

Patch Set 2 : Modify test results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (10 generated)
yuzuchan
PTAL
4 years, 9 months ago (2016-03-10 02:22:20 UTC) #3
hayato
lgtm
4 years, 9 months ago (2016-03-10 02:25:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783693002/1
4 years, 9 months ago (2016-03-10 02:26:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/194288)
4 years, 9 months ago (2016-03-10 03:44:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783693002/20001
4 years, 9 months ago (2016-03-10 04:45:48 UTC) #11
hayato
lgtm
4 years, 9 months ago (2016-03-10 04:46:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/155253)
4 years, 9 months ago (2016-03-10 04:54:19 UTC) #14
yuzuchan
tkent@-san, can you lgtm this CL? :)
4 years, 9 months ago (2016-03-10 04:59:15 UTC) #16
tkent
lgtm
4 years, 9 months ago (2016-03-10 05:14:35 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783693002/20001
4 years, 9 months ago (2016-03-10 05:15:13 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-10 06:40:38 UTC) #20
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9ca99ec409a1d6f7baf6dd3cd6929e81c967cac1 Cr-Commit-Position: refs/heads/master@{#380363}
4 years, 9 months ago (2016-03-10 06:41:48 UTC) #22
dglazkov
4 years, 7 months ago (2016-05-04 22:10:14 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1945823004/ by dglazkov@chromium.org.

The reason for reverting is: Turns out that the change is not Web-compatible.
See https://bugs.chromium.org/p/chromium/issues/detail?id=608006 for details..

Powered by Google App Engine
This is Rietveld 408576698