Chromium Code Reviews Chromium Code Reviews
Issue
1783673002:
Revert of Simplify the shutdown sequence of Oilpan's heap
DescriptionRevert of Simplify the shutdown sequence of Oilpan's heap (patchset #4 id:60001 of https://codereview.chromium.org/1754313002/ )
Reason for revert:
https://chromium.googlesource.com/chromium/src/+/5940f25b9d91258d698a5ce9f48e8a253c7b1652 caused the following crash:
https://bugs.chromium.org/p/chromium/issues/detail?id=593092
This CL needs to be reverted to revert the above CL.
Original issue's description:
> Simplify the shutdown sequence of Oilpan's heap
>
> The current shutdown sequence is more complicated than necessary
> since it was implemented in days when it was not guaranteed that
> the main thread is the last thread that gets detached.
>
> Today the main thread joins all other threads before calling Heap::shutdown(),
> so we can assume that the main thread is the last thread that gets detached.
> This CL simplifies the shutdown sequence relying on the assumption.
>
> BUG=
>
> Committed: https://crrev.com/3ae8ad9e6ddbfe21e31d889d4ce622a3ab09929d
> Cr-Commit-Position: refs/heads/master@{#379766}
TBR=keishi@chromium.org,sigbjornf@opera.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=
Patch Set 1 #
Messages
Total messages: 12 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
