String.prototype[Symbol.iterator] does RequireObjectCoercible(this)

String.prototype[Symbol.iterator] does RequireObjectCoercible(this)

BUG=v8:4348
R=adamk
LOG=Y

Committed: https://crrev.com/43adcd3c65466fa782e5d85700797d6f75bc1d10
Cr-Commit-Position: refs/heads/master@{#34647}

[Dan Ehrenberg, 2016-03-09 23:18:42]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-09 23:18:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783643002/1

[adamk, 2016-03-09 23:31:58]

https://codereview.chromium.org/1783643002/diff/1/src/js/string-iterator.js
File src/js/string-iterator.js (right):

https://codereview.chromium.org/1783643002/diff/1/src/js/string-iterator.js#n...
src/js/string-iterator.js:35: if (IS_NULL_OR_UNDEFINED(string)) {
There's a macro for this:

CHECK_OBJECT_COERCIBLE(string, 'String.prototype[Symbol.iterator]');

[commit-bot: I haz the power, 2016-03-09 23:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 23:46:23]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-03-09 23:53:59]

https://codereview.chromium.org/1783643002/diff/1/src/js/string-iterator.js
File src/js/string-iterator.js (right):

https://codereview.chromium.org/1783643002/diff/1/src/js/string-iterator.js#n...
src/js/string-iterator.js:35: if (IS_NULL_OR_UNDEFINED(string)) {
On 2016/03/09 at 23:31:58, adamk wrote:
> There's a macro for this:
> 
> CHECK_OBJECT_COERCIBLE(string, 'String.prototype[Symbol.iterator]');

Awesome, applied

[adamk, 2016-03-09 23:55:14]

lgtm

[Dan Ehrenberg, 2016-03-10 00:00:06]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-03-10 00:00:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783643002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783643002/20001

[commit-bot: I haz the power, 2016-03-10 00:11:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 00:11:20]

Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[Dan Ehrenberg, 2016-03-10 00:34:56]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-03-10 00:34:57]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1783643002/#ps40001
(title: "Remove RegExp changes accidentally added")

[commit-bot: I haz the power, 2016-03-10 00:35:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783643002/40001

[commit-bot: I haz the power, 2016-03-10 00:58:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-10 00:59:28]

Description was changed from

==========
String.prototype[Symbol.iterator] does RequireObjectCoercible(this)

BUG=v8:4348
R=adamk
LOG=Y
==========

to

==========
String.prototype[Symbol.iterator] does RequireObjectCoercible(this)

BUG=v8:4348
R=adamk
LOG=Y

Committed: https://crrev.com/43adcd3c65466fa782e5d85700797d6f75bc1d10
Cr-Commit-Position: refs/heads/master@{#34647}
==========

[commit-bot: I haz the power, 2016-03-10 00:59:28]

Patchset 3 (id:??) landed as
https://crrev.com/43adcd3c65466fa782e5d85700797d6f75bc1d10
Cr-Commit-Position: refs/heads/master@{#34647}