Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1783623005: Add mojo/c/system/{time.h,wait.h}. (Closed)

Created:
4 years, 9 months ago by viettrungluu
Modified:
4 years, 9 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add mojo/c/system/{time.h,wait.h}. time.h contains the types (previously in types.h) and MojoGetTimeTicks() (previously in functions.h). wait.h contains MojoWait() and MojoWaitMany() (previously in functions.h). handle.h gets MojoClose() (previously in functions.h). Removal of types.h and functions.h will be done separately. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a2e2b6d942f67ae2fe03bee670ce0e8bdc64718f

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -254 lines) Patch
M examples/tiny/tiny.c View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/android/system/core_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/embedder/entrypoints.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M mojo/edk/embedder/multiprocess_embedder_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/embedder/system_impl_private_entrypoints.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/edk/platform/test_stopwatch.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/platform/thread_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/platform/time_ticks.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/core.h View 2 chunks +10 lines, -3 lines 0 comments Download
M mojo/edk/system/test/timeouts.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/waiter.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/waiter_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/nacl/nonsfi/irt_mojo_nonsfi.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/nacl/nonsfi/irt_mojo_nonsfi.cc View 1 chunk +6 lines, -1 line 0 comments Download
M mojo/nacl/sfi/nacl_bindings/mojo_syscall.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/nacl/sfi/nacl_bindings_generator/libmojo.cc.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings_generator/mojo_irt.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/nacl/sfi/nacl_bindings_generator/mojo_syscall.cc.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/environment/async_waiter.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/system/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/c/system/core.h View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/c/system/functions.h View 2 chunks +5 lines, -122 lines 0 comments Download
M mojo/public/c/system/handle.h View 3 chunks +22 lines, -1 line 2 comments Download
M mojo/public/c/system/tests/core_perftest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest_pure_c.c View 1 chunk +2 lines, -2 lines 0 comments Download
A mojo/public/c/system/time.h View 1 chunk +50 lines, -0 lines 0 comments Download
M mojo/public/c/system/types.h View 1 chunk +4 lines, -23 lines 0 comments Download
A + mojo/public/c/system/wait.h View 3 chunks +5 lines, -32 lines 0 comments Download
M mojo/public/cpp/system/functions.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/system/handle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/platform/dart/dart_handle_watcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/platform/dart/mojo_natives.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/public/platform/nacl/libmojo.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/platform/nacl/mojo_irt.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/system_impl_private.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/system_impl_private_thunks.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/platform/native/system_thunks.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/platform/native_cgo/system_cgo.go View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/python/c_async_waiter.pxd View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/python/c_core.pxd View 2 chunks +19 lines, -17 lines 0 comments Download
M mojo/public/python/mojo_system.pyx View 4 chunks +4 lines, -4 lines 0 comments Download
M services/js/system/mojo_runner_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M services/vanadium/security/principal_service.go View 1 chunk +2 lines, -1 line 0 comments Download
M shell/child_process_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
viettrungluu
4 years, 9 months ago (2016-03-11 02:29:44 UTC) #1
jamesr
lgtm https://codereview.chromium.org/1783623005/diff/1/mojo/public/c/system/handle.h File mojo/public/c/system/handle.h (right): https://codereview.chromium.org/1783623005/diff/1/mojo/public/c/system/handle.h#newcode58 mojo/public/c/system/handle.h:58: #ifdef __cplusplus maybe this should go in macros.h ...
4 years, 9 months ago (2016-03-11 18:36:42 UTC) #3
viettrungluu
Thanks. https://codereview.chromium.org/1783623005/diff/1/mojo/public/c/system/handle.h File mojo/public/c/system/handle.h (right): https://codereview.chromium.org/1783623005/diff/1/mojo/public/c/system/handle.h#newcode58 mojo/public/c/system/handle.h:58: #ifdef __cplusplus On 2016/03/11 18:36:42, jamesr wrote: > ...
4 years, 9 months ago (2016-03-11 20:38:31 UTC) #4
viettrungluu
4 years, 9 months ago (2016-03-11 20:39:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a2e2b6d942f67ae2fe03bee670ce0e8bdc64718f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698