chrome/browser/android/compositor/scene_layer/tab_strip_scene_layer.cc - Issue 1783613004: CC Animation: Erase cc::LayerSettings everywhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/compositor/scene_layer/tab_strip_scene_layer.cc

Issue 1783613004: CC Animation: Erase cc::LayerSettings everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@eraseandroid

Patch Set: Rebase. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/test/layer_tree_host_common_test.cc ('K') | « chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc ('k') | chrome/browser/android/tab_android.cc » ('j') | content/browser/renderer_host/render_widget_host_view_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/compositor/scene_layer/tab_strip_scene_layer.cc

diff --git a/chrome/browser/android/compositor/scene_layer/tab_strip_scene_layer.cc b/chrome/browser/android/compositor/scene_layer/tab_strip_scene_layer.cc

index 48fd5c8b3bcccc67f07cf0402c90f4bd14039959..034a6480416333bf22c4fdcefca6e66e66954db3 100644

--- a/chrome/browser/android/compositor/scene_layer/tab_strip_scene_layer.cc

+++ b/chrome/browser/android/compositor/scene_layer/tab_strip_scene_layer.cc

@@ -5,7 +5,6 @@

#include "chrome/browser/android/compositor/scene_layer/tab_strip_scene_layer.h"

#include "base/android/jni_android.h"

-#include "cc/layers/layer_settings.h"

#include "cc/resources/scoped_ui_resource.h"

#include "chrome/browser/android/compositor/layer/tab_handle_layer.h"

#include "chrome/browser/android/compositor/layer_title_cache.h"

@@ -18,12 +17,9 @@ namespace android {

TabStripSceneLayer::TabStripSceneLayer(JNIEnv* env, jobject jobj)

: SceneLayer(env, jobj),

- tab_strip_layer_(

- cc::SolidColorLayer::Create(cc::LayerSettings())),

- new_tab_button_(

- cc::UIResourceLayer::Create(cc::LayerSettings())),

- model_selector_button_(

- cc::UIResourceLayer::Create(cc::LayerSettings())),

+ tab_strip_layer_(cc::SolidColorLayer::Create()),

+ new_tab_button_(cc::UIResourceLayer::Create()),

+ model_selector_button_(cc::UIResourceLayer::Create()),

background_tab_brightness_(1.f),

brightness_(1.f),

write_index_(0),