cc/layers/heads_up_display_layer.cc - Issue 1783613004: CC Animation: Erase cc::LayerSettings everywhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/heads_up_display_layer.cc

Issue 1783613004: CC Animation: Erase cc::LayerSettings everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@eraseandroid

Patch Set: Rebase. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/heads_up_display_layer.cc

diff --git a/cc/layers/heads_up_display_layer.cc b/cc/layers/heads_up_display_layer.cc

index a34ca42d6c93170eed50732aa0ac8029f9d2197d..62c4507cccfdf3d94b46e313aa746d3d225adef0 100644

--- a/cc/layers/heads_up_display_layer.cc

+++ b/cc/layers/heads_up_display_layer.cc

@@ -13,13 +13,12 @@

namespace cc {

-scoped_refptr<HeadsUpDisplayLayer> HeadsUpDisplayLayer::Create(

- const LayerSettings& settings) {

- return make_scoped_refptr(new HeadsUpDisplayLayer(settings));

+scoped_refptr<HeadsUpDisplayLayer> HeadsUpDisplayLayer::Create() {

+ return make_scoped_refptr(new HeadsUpDisplayLayer());

}

-HeadsUpDisplayLayer::HeadsUpDisplayLayer(const LayerSettings& settings)

- : Layer(settings),

+HeadsUpDisplayLayer::HeadsUpDisplayLayer()

+ : Layer(),

ajuma 2016/03/11 00:40:54 This line shouldn't be needed anymore. (And same c

loyso (OOO) 2016/03/11 03:26:57 Done.

typeface_(skia::AdoptRef(

SkTypeface::CreateFromName("times new roman", SkTypeface::kNormal))) {

if (!typeface_) {

« no previous file with comments | « cc/layers/heads_up_display_layer.h ('k') | cc/layers/heads_up_display_unittest.cc » ('j') | cc/layers/layer_utils_unittest.cc » ('J')