simplify function coercions -- DDC can generate function types in place

simplify function coercions -- DDC can generate function types in place

R=leafp@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/d051cbd7cb9de070f7210dc557d76df37900867c

[Jennifer Messerly, 2016-03-12 00:36:56]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Jennifer Messerly, 2016-03-12 00:36:56]

Seems like we can just emit them in place. We might want caching, but the same
is probably true of our function expressions and things like that, so maybe
easier to attack it later when we focus on perf.

https://codereview.chromium.org/1783603009/diff/1/test/codegen/expect/collect...
File test/codegen/expect/collection/src/priority_queue.js (right):

https://codereview.chromium.org/1783603009/diff/1/test/codegen/expect/collect...
test/codegen/expect/collection/src/priority_queue.js:103:
list[dartx.sort](dart.as(this.comparison, dart.functionType(core.int, [E, E])));
looks like a bug fix. We weren't instantiating the typedef with E.

[Leaf, 2016-03-12 01:14:05]

lgtm

https://codereview.chromium.org/1783603009/diff/1/lib/src/codegen/reify_coerc...
File lib/src/codegen/reify_coercions.dart (right):

https://codereview.chromium.org/1783603009/diff/1/lib/src/codegen/reify_coerc...
lib/src/codegen/reify_coercions.dart:91: /// possibly recording additional
coercions functions and typedefs to
Probably should delete the last two lines of this comment now.

[Jennifer Messerly, 2016-03-14 17:37:47]

Thanks!

https://codereview.chromium.org/1783603009/diff/1/lib/src/codegen/reify_coerc...
File lib/src/codegen/reify_coercions.dart (right):

https://codereview.chromium.org/1783603009/diff/1/lib/src/codegen/reify_coerc...
lib/src/codegen/reify_coercions.dart:91: /// possibly recording additional
coercions functions and typedefs to
On 2016/03/12 01:14:05, Leaf wrote:
> Probably should delete the last two lines of this comment now.

Oops! Done.

[Jennifer Messerly, 2016-03-14 17:38:01]

Description was changed from

==========
simplify function coercions -- DDC can generate function types in place
==========

to

==========
simplify function coercions -- DDC can generate function types in place

R=leafp@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/d051cbd7cb9de070f7210dc557d7...
==========

[Jennifer Messerly, 2016-03-14 17:38:03]

Committed patchset #2 (id:20001) manually as
d051cbd7cb9de070f7210dc557d76df37900867c (presubmit successful).