Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1783603006: Revert of When not writing to file in DM, spew verbose output to stderr (Closed)

Created:
4 years, 9 months ago by mtklein
Modified:
4 years, 9 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org, bsalomon
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of When not writing to file in DM, spew verbose output to stderr (patchset #1 id:1 of https://codereview.chromium.org/1788743002/ ) Reason for revert: Looks like not all the bots are using --writePath (think, Valgrind, *SAN) so this causes those bots to spew like crazy. Looks like we need to find a more explicit way to make this mode work. Original issue's description: > When not writing to file in DM, spew verbose output to stderr > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1788743002 > > Committed: https://skia.googlesource.com/skia/+/40dec542cc12b354762bca2c0d68bc419f0cbebd TBR=egdaniel@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/51c8cfc64c7286ad8a392064cd376bb9974c7bc1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M dm/DM.cpp View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of When not writing to file in DM, spew verbose output to stderr
4 years, 9 months ago (2016-03-11 20:58:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783603006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783603006/1
4 years, 9 months ago (2016-03-11 20:59:05 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 20:59:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/51c8cfc64c7286ad8a392064cd376bb9974c7bc1

Powered by Google App Engine
This is Rietveld 408576698