|
|
Chromium Code Reviews|
Created:
4 years, 9 months ago by qiangchen Modified:
4 years, 9 months ago Reviewers:
DaleCurtis CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Use system timestamp as capture timestamp (patchset #1 id:1 of https://codereview.chromium.org/1671943003/ )
Reason for revert:
WebRTC part of the issue has been fixed.
Thus we can reland the camera timestamp CL.
Original issue's description:
> Use system timestamp as capture timestamp
>
> For rendering smoothness, we used camera timestamp as capture timestamp,
> but if the clockrate of the camera is different from the system clock,
> it will make audio-video out of sync. So we change it back so far.
>
> This CL is essentially a revert of
> https://codereview.chromium.org/1324683004/
> https://codereview.chromium.org/1421583007/
>
> P.S. An ideal solution is that we should take in camera
> timestamp, but smoothly aligned with system clock. But at
> this point, we should make a quick CL to resolve this issue.
>
> BUG=584015
>
> Committed: https://crrev.com/8e0974d2b27ab55a8df948b86804bf0f11c036e2
> Cr-Commit-Position: refs/heads/master@{#373966}
TBR=dalecurtis@chromium.org,pbos@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=584015
Committed: https://crrev.com/10127cd472aa0e25de29b9debfbe1933f39ea7cd
Cr-Commit-Position: refs/heads/master@{#380721}
Patch Set 1 #
Messages
Total messages: 24 (12 generated)
Created Revert of Use system timestamp as capture timestamp
Description was changed from ========== Revert of Use system timestamp as capture timestamp (patchset #1 id:1 of https://codereview.chromium.org/1671943003/ ) Reason for revert: WebRTC part of the issue has been fixed. Thus we can reland the camera timestamp CL. Original issue's description: > Use system timestamp as capture timestamp > > For rendering smoothness, we used camera timestamp as capture timestamp, > but if the clockrate of the camera is different from the system clock, > it will make audio-video out of sync. So we change it back so far. > > This CL is essentially a revert of > https://codereview.chromium.org/1324683004/ > https://codereview.chromium.org/1421583007/ > > P.S. An ideal solution is that we should take in camera > timestamp, but smoothly aligned with system clock. But at > this point, we should make a quick CL to resolve this issue. > > BUG=584015 > > Committed: https://crrev.com/8e0974d2b27ab55a8df948b86804bf0f11c036e2 > Cr-Commit-Position: refs/heads/master@{#373966} TBR=dalecurtis@chromium.org,pbos@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=584015 ========== to ========== Revert of Use system timestamp as capture timestamp (patchset #1 id:1 of https://codereview.chromium.org/1671943003/ ) Reason for revert: WebRTC part of the issue has been fixed. Thus we can reland the camera timestamp CL. Original issue's description: > Use system timestamp as capture timestamp > > For rendering smoothness, we used camera timestamp as capture timestamp, > but if the clockrate of the camera is different from the system clock, > it will make audio-video out of sync. So we change it back so far. > > This CL is essentially a revert of > https://codereview.chromium.org/1324683004/ > https://codereview.chromium.org/1421583007/ > > P.S. An ideal solution is that we should take in camera > timestamp, but smoothly aligned with system clock. But at > this point, we should make a quick CL to resolve this issue. > > BUG=584015 > > Committed: https://crrev.com/8e0974d2b27ab55a8df948b86804bf0f11c036e2 > Cr-Commit-Position: refs/heads/master@{#373966} TBR=dalecurtis@chromium.org,pbos@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=584015 ==========
qiangchen@chromium.org changed reviewers: - dalecurtis@chromium.org
qiangchen@chromium.org changed reviewers: + mcasas@chromium.org - pbos@chromium.org
This is the Revert CL. The change is identical with that CL.
On 2016/03/10 20:59:25, qiangchenC wrote: > This is the Revert CL. > The change is identical with that CL. You should ask the original reviewers or, since it seems to be identical, just send it to the CQ (note that you already have the TBR= line).
qiangchen@chromium.org changed reviewers: - mcasas@chromium.org
The CQ bit was checked by qiangchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783603004/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
qiangchen@chromium.org changed reviewers: + dalecurtis@chromium.org
Hi, Dale
This is a revert CL of a previous "revert".
As danilchap@ fixed the webrtc part in
https://codereview.webrtc.org/1693443002 resolving Audio-Video out-of-sync
issue. We can switch back to use camera timestamps, as they are smoother. I've
tested, it works well.
Thanks.
lgtm
The CQ bit was checked by qiangchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783603004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by qiangchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783603004/1
Message was sent while issue was closed.
Description was changed from ========== Revert of Use system timestamp as capture timestamp (patchset #1 id:1 of https://codereview.chromium.org/1671943003/ ) Reason for revert: WebRTC part of the issue has been fixed. Thus we can reland the camera timestamp CL. Original issue's description: > Use system timestamp as capture timestamp > > For rendering smoothness, we used camera timestamp as capture timestamp, > but if the clockrate of the camera is different from the system clock, > it will make audio-video out of sync. So we change it back so far. > > This CL is essentially a revert of > https://codereview.chromium.org/1324683004/ > https://codereview.chromium.org/1421583007/ > > P.S. An ideal solution is that we should take in camera > timestamp, but smoothly aligned with system clock. But at > this point, we should make a quick CL to resolve this issue. > > BUG=584015 > > Committed: https://crrev.com/8e0974d2b27ab55a8df948b86804bf0f11c036e2 > Cr-Commit-Position: refs/heads/master@{#373966} TBR=dalecurtis@chromium.org,pbos@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=584015 ========== to ========== Revert of Use system timestamp as capture timestamp (patchset #1 id:1 of https://codereview.chromium.org/1671943003/ ) Reason for revert: WebRTC part of the issue has been fixed. Thus we can reland the camera timestamp CL. Original issue's description: > Use system timestamp as capture timestamp > > For rendering smoothness, we used camera timestamp as capture timestamp, > but if the clockrate of the camera is different from the system clock, > it will make audio-video out of sync. So we change it back so far. > > This CL is essentially a revert of > https://codereview.chromium.org/1324683004/ > https://codereview.chromium.org/1421583007/ > > P.S. An ideal solution is that we should take in camera > timestamp, but smoothly aligned with system clock. But at > this point, we should make a quick CL to resolve this issue. > > BUG=584015 > > Committed: https://crrev.com/8e0974d2b27ab55a8df948b86804bf0f11c036e2 > Cr-Commit-Position: refs/heads/master@{#373966} TBR=dalecurtis@chromium.org,pbos@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=584015 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert of Use system timestamp as capture timestamp (patchset #1 id:1 of https://codereview.chromium.org/1671943003/ ) Reason for revert: WebRTC part of the issue has been fixed. Thus we can reland the camera timestamp CL. Original issue's description: > Use system timestamp as capture timestamp > > For rendering smoothness, we used camera timestamp as capture timestamp, > but if the clockrate of the camera is different from the system clock, > it will make audio-video out of sync. So we change it back so far. > > This CL is essentially a revert of > https://codereview.chromium.org/1324683004/ > https://codereview.chromium.org/1421583007/ > > P.S. An ideal solution is that we should take in camera > timestamp, but smoothly aligned with system clock. But at > this point, we should make a quick CL to resolve this issue. > > BUG=584015 > > Committed: https://crrev.com/8e0974d2b27ab55a8df948b86804bf0f11c036e2 > Cr-Commit-Position: refs/heads/master@{#373966} TBR=dalecurtis@chromium.org,pbos@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=584015 ========== to ========== Revert of Use system timestamp as capture timestamp (patchset #1 id:1 of https://codereview.chromium.org/1671943003/ ) Reason for revert: WebRTC part of the issue has been fixed. Thus we can reland the camera timestamp CL. Original issue's description: > Use system timestamp as capture timestamp > > For rendering smoothness, we used camera timestamp as capture timestamp, > but if the clockrate of the camera is different from the system clock, > it will make audio-video out of sync. So we change it back so far. > > This CL is essentially a revert of > https://codereview.chromium.org/1324683004/ > https://codereview.chromium.org/1421583007/ > > P.S. An ideal solution is that we should take in camera > timestamp, but smoothly aligned with system clock. But at > this point, we should make a quick CL to resolve this issue. > > BUG=584015 > > Committed: https://crrev.com/8e0974d2b27ab55a8df948b86804bf0f11c036e2 > Cr-Commit-Position: refs/heads/master@{#373966} TBR=dalecurtis@chromium.org,pbos@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=584015 Committed: https://crrev.com/10127cd472aa0e25de29b9debfbe1933f39ea7cd Cr-Commit-Position: refs/heads/master@{#380721} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/10127cd472aa0e25de29b9debfbe1933f39ea7cd Cr-Commit-Position: refs/heads/master@{#380721} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
