Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1783603004: Revert of Use system timestamp as capture timestamp (Closed)

Created:
4 years, 9 months ago by qiangchen
Modified:
4 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use system timestamp as capture timestamp (patchset #1 id:1 of https://codereview.chromium.org/1671943003/ ) Reason for revert: WebRTC part of the issue has been fixed. Thus we can reland the camera timestamp CL. Original issue's description: > Use system timestamp as capture timestamp > > For rendering smoothness, we used camera timestamp as capture timestamp, > but if the clockrate of the camera is different from the system clock, > it will make audio-video out of sync. So we change it back so far. > > This CL is essentially a revert of > https://codereview.chromium.org/1324683004/ > https://codereview.chromium.org/1421583007/ > > P.S. An ideal solution is that we should take in camera > timestamp, but smoothly aligned with system clock. But at > this point, we should make a quick CL to resolve this issue. > > BUG=584015 > > Committed: https://crrev.com/8e0974d2b27ab55a8df948b86804bf0f11c036e2 > Cr-Commit-Position: refs/heads/master@{#373966} TBR=dalecurtis@chromium.org,pbos@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=584015 Committed: https://crrev.com/10127cd472aa0e25de29b9debfbe1933f39ea7cd Cr-Commit-Position: refs/heads/master@{#380721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M media/capture/video/mac/video_capture_device_mac.mm View 1 chunk +11 lines, -1 line 0 comments Download
M media/capture/video/win/video_capture_device_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (12 generated)
qiangchen
Created Revert of Use system timestamp as capture timestamp
4 years, 9 months ago (2016-03-10 20:54:03 UTC) #1
qiangchen
This is the Revert CL. The change is identical with that CL.
4 years, 9 months ago (2016-03-10 20:59:25 UTC) #5
mcasas
On 2016/03/10 20:59:25, qiangchenC wrote: > This is the Revert CL. > The change is ...
4 years, 9 months ago (2016-03-10 23:17:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783603004/1
4 years, 9 months ago (2016-03-10 23:27:56 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 9 months ago (2016-03-10 23:27:59 UTC) #11
qiangchen
Hi, Dale This is a revert CL of a previous "revert". As danilchap@ fixed the ...
4 years, 9 months ago (2016-03-10 23:36:45 UTC) #13
DaleCurtis
lgtm
4 years, 9 months ago (2016-03-10 23:38:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783603004/1
4 years, 9 months ago (2016-03-10 23:41:25 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/193837)
4 years, 9 months ago (2016-03-11 04:35:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783603004/1
4 years, 9 months ago (2016-03-11 20:38:35 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 20:44:53 UTC) #22
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 20:47:09 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10127cd472aa0e25de29b9debfbe1933f39ea7cd
Cr-Commit-Position: refs/heads/master@{#380721}

Powered by Google App Engine
This is Rietveld 408576698