Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: src/profile-generator.h

Issue 17836002: CPUProfiler: Simplify CodeEntry constructor calls. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/profile-generator.cc » ('j') | test/cctest/test-cpu-profiler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profile-generator.h
diff --git a/src/profile-generator.h b/src/profile-generator.h
index 7a5e1f2fc56ed90d61840356b15da63d51f297c4..8784c4b042ea77beb921abcd2c7073b6aab3452a 100644
--- a/src/profile-generator.h
+++ b/src/profile-generator.h
@@ -99,15 +99,16 @@ class CodeEntry {
INLINE(CodeEntry(Logger::LogEventsAndTags tag,
const char* name_prefix,
const char* name,
- const char* resource_name,
- int line_number,
- int security_token_id));
+ int security_token_id = TokenEnumerator::kNoSecurityToken,
+ const char* resource_name = "",
+ int line_number = v8::CpuProfileNode::kNoLineNumberInfo));
~CodeEntry();
INLINE(bool is_js_function() const) { return is_js_function_tag(tag_); }
INLINE(const char* name_prefix() const) { return name_prefix_; }
INLINE(bool has_name_prefix() const) { return name_prefix_[0] != '\0'; }
INLINE(const char* name() const) { return name_; }
+ INLINE(int script_id() const) { return script_id_; }
INLINE(const char* resource_name() const) { return resource_name_; }
INLINE(int line_number() const) { return line_number_; }
INLINE(void set_shared_id(int shared_id)) { shared_id_ = shared_id; }
@@ -130,6 +131,7 @@ class CodeEntry {
Logger::LogEventsAndTags tag_;
const char* name_prefix_;
const char* name_;
+ int script_id_;
const char* resource_name_;
int line_number_;
int shared_id_;
@@ -322,8 +324,8 @@ class CpuProfilesCollection {
void RemoveProfile(CpuProfile* profile);
bool HasDetachedProfiles() { return detached_profiles_.length() > 0; }
- CodeEntry* NewCodeEntry(Logger::LogEventsAndTags tag,
- Name* name, String* resource_name, int line_number);
+ CodeEntry* NewCodeEntry(Logger::LogEventsAndTags tag, Name* name,
yurys 2013/06/26 09:34:47 Revert this?
+ String* resource_name, int line_number);
CodeEntry* NewCodeEntry(Logger::LogEventsAndTags tag, const char* name);
CodeEntry* NewCodeEntry(Logger::LogEventsAndTags tag,
const char* name_prefix, Name* name);
« no previous file with comments | « no previous file | src/profile-generator.cc » ('j') | test/cctest/test-cpu-profiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698