Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 17836002: CPUProfiler: Simplify CodeEntry constructor calls. (Closed)

Created:
7 years, 6 months ago by loislo
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne, yurys, Yang
CC:
v8-dev
Visibility:
Public.

Description

CPUProfiler: Simplify CodeEntry constructor calls. In almost all the places where we create CodeEntry we use default values. Lets move them into arguments default values. BUG=none TEST=no logic changes. R=yangguo@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15333 Committed: https://code.google.com/p/v8/source/detail?r=15340

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Patch Set 3 : win debug bot fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -70 lines) Patch
M src/profile-generator.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M src/profile-generator.cc View 1 2 6 chunks +6 lines, -16 lines 0 comments Download
M src/profile-generator-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 11 chunks +27 lines, -49 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
loislo
7 years, 6 months ago (2013-06-26 08:31:07 UTC) #1
yurys
lgtm https://codereview.chromium.org/17836002/diff/1/src/profile-generator.h File src/profile-generator.h (right): https://codereview.chromium.org/17836002/diff/1/src/profile-generator.h#newcode327 src/profile-generator.h:327: CodeEntry* NewCodeEntry(Logger::LogEventsAndTags tag, Name* name, Revert this? https://codereview.chromium.org/17836002/diff/1/test/cctest/test-cpu-profiler.cc ...
7 years, 6 months ago (2013-06-26 09:34:47 UTC) #2
Yang
On 2013/06/26 09:34:47, Yury Semikhatsky wrote: > lgtm > > https://codereview.chromium.org/17836002/diff/1/src/profile-generator.h > File src/profile-generator.h (right): ...
7 years, 6 months ago (2013-06-26 09:54:21 UTC) #3
loislo
Committed patchset #2 manually as r15333 (presubmit successful).
7 years, 6 months ago (2013-06-26 09:55:45 UTC) #4
loislo
7 years, 6 months ago (2013-06-26 16:04:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r15340 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698