[wasm] Encode function signatures, bodies, and names as separate sections.

test/unittests/wasm/module-decoder-unittest.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "test/unittests/test-utils.h"
 
 #include "src/wasm/module-decoder.h"
 #include "src/wasm/wasm-macro-gen.h"
 #include "src/wasm/wasm-opcodes.h"
 
 namespace v8 {
 namespace internal {
 namespace wasm {
 
 #define EMPTY_FUNCTION(sig_index) 0, SIG_INDEX(sig_index), U16_LE(0)
+#define EMPTY_BODY 0
+#define NOP_BODY 2, 0, kExprNop
 #define VOID_VOID_SIG 0, kLocalVoid
 #define INT_INT_SIG 1, kLocalI32, kLocalI32
 
 #define EXPECT_VERIFIES(data)                                         \
   do {                                                                \
     ModuleResult result = DecodeModule(data, data + arraysize(data)); \
     EXPECT_TRUE(result.ok());                                         \
     if (result.val) delete result.val;                                \
   } while (false)
 
@@ skipping 1026 matching lines @@
   static const byte data[] = {
       kDeclSignatures, 1, VOID_VOID_SIG, kDeclImportTable, 1,
       IMPORT_SIG_INDEX(0),  // sig index
       NAME_LENGTH(1), 'm',  // module name
       NAME_LENGTH(1), 'f',  // function name
   };
 
   EXPECT_OFF_END_FAILURE(data, 5, sizeof(data));
 }
 
-TEST_F(WasmModuleVerifyTest, ExportTable_empty) {
+TEST_F(WasmModuleVerifyTest, ExportTable_empty1) {
+  static const byte data[] = {kDeclSignatures,  1, VOID_VOID_SIG,
+                              kDeclFunctions,   1, EMPTY_FUNCTION(0),
+                              kDeclExportTable, 0};
+  EXPECT_VERIFIES(data);
+}
+
+TEST_F(WasmModuleVerifyTest, ExportTable_empty2) {
   static const byte data[] = {kDeclSignatures,  0, kDeclFunctions, 0,
                               kDeclExportTable, 0};
-  EXPECT_VERIFIES(data);
+  // TODO(titzer): current behavior treats empty functions section as missing.
+  EXPECT_FAILURE(data);
 }
 
 TEST_F(WasmModuleVerifyTest, ExportTable_NoFunctions1) {
   static const byte data[] = {kDeclSignatures, 0, kDeclExportTable, 0};
   EXPECT_FAILURE(data);
 }
 
 TEST_F(WasmModuleVerifyTest, ExportTable_NoFunctions2) {
   static const byte data[] = {kDeclExportTable, 0};
   EXPECT_FAILURE(data);
@@ skipping 79 matching lines @@
       NO_NAME                // --
   };
 
   for (int length = 13; length < sizeof(data); length++) {
     ModuleResult result = DecodeModule(data, data + length);
     EXPECT_FALSE(result.ok());
     if (result.val) delete result.val;
   }
 }
 
+#define SIGNATURES_SECTION(count, ...) \
+  kDeclSignatures, U32V_1(count), __VA_ARGS__
+#define FUNCTION_SIGNATURES_SECTION(count, ...) \
+  kDeclFunctionSignatures, U32V_1(count), __VA_ARGS__
+#define FUNCTION_BODIES_SECTION(count, ...) \
+  kDeclFunctionBodies, U32V_1(count), __VA_ARGS__
+#define NAMES_SECTION(count, ...) kDeclNames, U32V_1(count), __VA_ARGS__
+
+#define FOO_STRING 3, 'f', 'o', 'o'
+#define NO_LOCAL_NAMES 0
+
+#define EMPTY_SIGNATURES_SECTION kDeclSignatures, 0
+#define EMPTY_FUNCTION_SIGNATURES_SECTION kDeclFunctionSignatures, 0
+#define EMPTY_FUNCTION_BODIES_SECTION kDeclFunctionBodies, 0
+#define EMPTY_NAMES_SECTION kDeclNames, 0
+
+TEST_F(WasmModuleVerifyTest, FunctionSignatures_empty) {
+  static const byte data[] = {kDeclSignatures, 0, kDeclFunctionSignatures, 0};
+  EXPECT_VERIFIES(data);
+}
+
+TEST_F(WasmModuleVerifyTest, FunctionSignatures_one) {
+  static const byte data[] = {SIGNATURES_SECTION(1, VOID_VOID_SIG),
+                              FUNCTION_SIGNATURES_SECTION(1, 0)};
+  EXPECT_VERIFIES(data);
+}
+
+TEST_F(WasmModuleVerifyTest, FunctionBodies_empty) {
+  static const byte data[] = {EMPTY_SIGNATURES_SECTION,
+                              EMPTY_FUNCTION_SIGNATURES_SECTION,
+                              EMPTY_FUNCTION_BODIES_SECTION};
+  EXPECT_VERIFIES(data);
+}
+
+TEST_F(WasmModuleVerifyTest, FunctionBodies_one_empty) {
+  static const byte data[] = {SIGNATURES_SECTION(1, VOID_VOID_SIG),
+                              FUNCTION_SIGNATURES_SECTION(1, 0),
+                              FUNCTION_BODIES_SECTION(1, EMPTY_BODY)};
+  EXPECT_VERIFIES(data);
+}
+
+TEST_F(WasmModuleVerifyTest, FunctionBodies_one_nop) {
+  static const byte data[] = {SIGNATURES_SECTION(1, VOID_VOID_SIG),
+                              FUNCTION_SIGNATURES_SECTION(1, 0),
+                              FUNCTION_BODIES_SECTION(1, NOP_BODY)};
+  EXPECT_VERIFIES(data);
+}
+
+TEST_F(WasmModuleVerifyTest, FunctionBodies_count_mismatch1) {
+  static const byte data[] = {SIGNATURES_SECTION(1, VOID_VOID_SIG),
+                              FUNCTION_SIGNATURES_SECTION(2, 0, 0),
+                              FUNCTION_BODIES_SECTION(1, EMPTY_BODY)};
+  EXPECT_FAILURE(data);
+}
+
+TEST_F(WasmModuleVerifyTest, FunctionBodies_count_mismatch2) {
+  static const byte data[] = {SIGNATURES_SECTION(1, VOID_VOID_SIG),
+                              FUNCTION_SIGNATURES_SECTION(1, 0),
+                              FUNCTION_BODIES_SECTION(2, NOP_BODY, NOP_BODY)};
+  EXPECT_FAILURE(data);
+}
+
+TEST_F(WasmModuleVerifyTest, Names_empty) {
+  static const byte data[] = {
+      EMPTY_SIGNATURES_SECTION, EMPTY_FUNCTION_SIGNATURES_SECTION,
+      EMPTY_FUNCTION_BODIES_SECTION, EMPTY_NAMES_SECTION};
+  EXPECT_VERIFIES(data);
+}
+
+TEST_F(WasmModuleVerifyTest, Names_one_empty) {
+  static const byte data[] = {
+      SIGNATURES_SECTION(1, VOID_VOID_SIG),         // --
+      FUNCTION_SIGNATURES_SECTION(1, 0),            // --
+      FUNCTION_BODIES_SECTION(1, EMPTY_BODY),       // --
+      NAMES_SECTION(1, FOO_STRING, NO_LOCAL_NAMES)  // --
+  };
+  EXPECT_VERIFIES(data);
+}
+
+TEST_F(WasmModuleVerifyTest, Names_two_empty) {
+  static const byte data[] = {
+      SIGNATURES_SECTION(1, VOID_VOID_SIG),                // --
+      FUNCTION_SIGNATURES_SECTION(2, 0, 0),                // --
+      FUNCTION_BODIES_SECTION(2, EMPTY_BODY, EMPTY_BODY),  // --
+      NAMES_SECTION(2, FOO_STRING, NO_LOCAL_NAMES,         // --
+                    FOO_STRING, NO_LOCAL_NAMES)            // --
+  };
+  EXPECT_VERIFIES(data);
+}
+
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8