Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1783583003: Add SkScalarTruncToScalar and speed up SkScalarFraction. (Closed)

Created:
4 years, 9 months ago by bungeman-skia
Modified:
4 years, 9 months ago
Reviewers:
dogben, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M include/core/SkScalar.h View 5 chunks +7 lines, -2 lines 0 comments Download
M include/private/SkFloatingPoint.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783583003/1
4 years, 9 months ago (2016-03-10 20:44:56 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 21:00:47 UTC) #5
bungeman-skia
https://codereview.chromium.org/1779083003/ proposed to use this, but it seemed extremely slow.
4 years, 9 months ago (2016-03-10 21:04:33 UTC) #8
dogben
lgtm
4 years, 9 months ago (2016-03-10 21:16:27 UTC) #9
reed1
lgtm
4 years, 9 months ago (2016-03-10 21:19:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783583003/1
4 years, 9 months ago (2016-03-10 21:38:36 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 21:39:33 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dd67e3d1b3c1e9f400f1ddd37e9e52c8a2952eec

Powered by Google App Engine
This is Rietveld 408576698