Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1783553005: [Media Router WebUI] Fix AX_TEXT_04 and AX_FOCUS_01 warnings. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Fix AX_TEXT_04 and AX_FOCUS_01 warnings. Previously, the <span> was being hidden, not the entire <a> element. This meant <a> was still focusable even though the text is hidden. This change resolves both of these warnings. BUG=591554, 591553 Committed: https://crrev.com/5a93e2c8f2a0bdcdf572034ac735587f50749903 Cr-Commit-Position: refs/heads/master@{#381387}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/webui/media_router/media_router_elements_browsertest.js View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
apacible
PTAL, thanks!
4 years, 9 months ago (2016-03-10 21:19:48 UTC) #8
imcheng
lgtm
4 years, 9 months ago (2016-03-15 21:36:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783553005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783553005/20001
4 years, 9 months ago (2016-03-15 23:26:09 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-16 02:42:36 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 02:43:36 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a93e2c8f2a0bdcdf572034ac735587f50749903
Cr-Commit-Position: refs/heads/master@{#381387}

Powered by Google App Engine
This is Rietveld 408576698