Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1783553004: Fix DCHECK/crash in WindowManagerState (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECK/crash in WindowManagerState On linux we can get events outside the bounds of the window, which causes problems for WindowManagerState. This fixes that. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/94838bc0326ade3c225ee1c0597d6c5d44a9c0b1 Cr-Commit-Position: refs/heads/master@{#380456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M components/mus/ws/window_manager_state.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sky
4 years, 9 months ago (2016-03-10 19:27:15 UTC) #1
sky
I'll add a test separately, but this is causing DCHECKs so want to land a ...
4 years, 9 months ago (2016-03-10 19:27:32 UTC) #2
Ben Goodger (Google)
lgtm
4 years, 9 months ago (2016-03-10 19:57:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783553004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783553004/1
4 years, 9 months ago (2016-03-10 20:07:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 20:42:57 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 20:43:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94838bc0326ade3c225ee1c0597d6c5d44a9c0b1
Cr-Commit-Position: refs/heads/master@{#380456}

Powered by Google App Engine
This is Rietveld 408576698