Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1783533003: Moves mojo_application_manifest to data_deps (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
CC:
chromium-reviews, rjkroege, feature-media-reviews_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves mojo_application_manifest to data_deps Otherwise they aren't picked up as runtime dependencies and isolates won't work. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/e5b6ffe4098f8f6f055397302022b6a03d698acb Cr-Commit-Position: refs/heads/master@{#380347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -39 lines) Patch
M ash/mus/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/mash/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M components/filesystem/BUILD.gn View 4 chunks +5 lines, -2 lines 0 comments Download
M components/font_service/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M components/leveldb/BUILD.gn View 4 chunks +5 lines, -2 lines 0 comments Download
M components/mus/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M components/profile_service/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/resource_provider/BUILD.gn View 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M mash/browser_driver/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M mash/example/views_examples/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mash/init/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M mash/login/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mash/quick_launch/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mash/screenlock/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mash/shell/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M mash/task_viewer/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mash/wm/BUILD.gn View 4 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/services/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/catalog/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/services/tracing/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/shell/background/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/runner/child/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mojo/shell/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/tests/connect/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M mojo/shell/tests/lifecycle/BUILD.gn View 4 chunks +9 lines, -3 lines 0 comments Download
M mojo/shell/tests/shell/BUILD.gn View 5 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 9 months ago (2016-03-10 01:13:13 UTC) #1
Ben Goodger (Google)
you can tbr this kind of thing fwiw lgtm
4 years, 9 months ago (2016-03-10 02:42:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783533003/1
4 years, 9 months ago (2016-03-10 03:37:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 05:45:35 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 05:46:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5b6ffe4098f8f6f055397302022b6a03d698acb
Cr-Commit-Position: refs/heads/master@{#380347}

Powered by Google App Engine
This is Rietveld 408576698