Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2786)

Unified Diff: src/log.cc

Issue 1783483002: [interpreter] Add support for scalable operands. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Re-generate golden files. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/register-translator.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index e520ff6aed04aada83d0aacf5b0231ca36bef32f..1f5e84372c4698fd9cdd827904acef8f416633cf 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -1607,12 +1607,23 @@ void Logger::LogCodeObjects() {
void Logger::LogBytecodeHandlers() {
if (!FLAG_ignition) return;
+ interpreter::Interpreter* interpreter = isolate_->interpreter();
const int last_index = static_cast<int>(interpreter::Bytecode::kLast);
- for (int index = 0; index <= last_index; ++index) {
- interpreter::Bytecode bytecode = interpreter::Bytecodes::FromByte(index);
- Code* code = isolate_->interpreter()->GetBytecodeHandler(bytecode);
- CodeCreateEvent(Logger::BYTECODE_HANDLER_TAG, AbstractCode::cast(code),
- interpreter::Bytecodes::ToString(bytecode));
+ for (auto operand_scale = interpreter::OperandScale::kSingle;
+ operand_scale <= interpreter::OperandScale::kMaxValid;
+ operand_scale =
+ interpreter::Bytecodes::NextOperandScale(operand_scale)) {
+ for (int index = 0; index <= last_index; ++index) {
+ interpreter::Bytecode bytecode = interpreter::Bytecodes::FromByte(index);
+ if (interpreter::Interpreter::BytecodeHasHandler(bytecode,
+ operand_scale)) {
+ Code* code = interpreter->GetBytecodeHandler(bytecode, operand_scale);
+ std::string bytecode_name =
+ interpreter::Bytecodes::ToString(bytecode, operand_scale);
+ CodeCreateEvent(Logger::BYTECODE_HANDLER_TAG, AbstractCode::cast(code),
+ bytecode_name.c_str());
+ }
+ }
}
}
« no previous file with comments | « src/interpreter/register-translator.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698