Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: src/objects-debug.cc

Issue 1783483002: [interpreter] Add support for scalable operands. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Incorporate latest review comments from rmcilroy. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-debug.cc
diff --git a/src/objects-debug.cc b/src/objects-debug.cc
index 0be32b62906186b40e685cea218f4b54106ae4e7..b023b03aea39a2ea791ea0eacf6e1428eeced775 100644
--- a/src/objects-debug.cc
+++ b/src/objects-debug.cc
@@ -229,6 +229,10 @@ void ByteArray::ByteArrayVerify() {
void BytecodeArray::BytecodeArrayVerify() {
// TODO(oth): Walk bytecodes and immediate values to validate sanity.
+ // - All bytecodes are known and well formed.
+ // - Jumps must go to new instructions starts.
+ // - No Illegal bytecodes.
+ // - No consecutive sequences of prefix Wide / ExtraWide.
CHECK(IsBytecodeArray());
CHECK(constant_pool()->IsFixedArray());
VerifyHeapPointer(constant_pool());

Powered by Google App Engine
This is Rietveld 408576698