Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 1783443003: Build HarfBuzz as loadable module when chromeos=1 under Linux (Closed)

Created:
4 years, 9 months ago by drott
Modified:
4 years, 5 months ago
CC:
blink-reviews, chromium-reviews, kalyank, kinuko+watch, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build HarfBuzz as loadable module when chromeos=1 under Linux This is a work-in-progress CL, it currently fails to link libash_sysui and libquickstart. BUG=589342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -145 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download
M ash/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/harfbuzz-ng/BUILD.gn View 3 chunks +79 lines, -144 lines 0 comments Download
A third_party/harfbuzz-ng/harfbuzz.gni View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/harfbuzz-ng/harfbuzz.gypi View 1 chunk +99 lines, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
drott
The first failure I get: FAILED: python "/usr/local/google/home/drott/dev/blink/src/build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --sofile="./libdesktop_wm_library.so" --tocfile="./libdesktop_wm_library.so.TOC" --output="./libdesktop_wm_library.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ ...
4 years, 9 months ago (2016-03-09 14:15:00 UTC) #2
Dirk Pranke
4 years, 9 months ago (2016-03-09 20:31:03 UTC) #3
As I just noted on the chromium-dev thread, I'm confused by the idea of this
patch. I don't think we need to go down this route, but maybe I'm missing
something ...

Powered by Google App Engine
This is Rietveld 408576698