Support dispatching ServiceWorker FetchEvent and receiving response

content/common/DEPS

Index: content/common/DEPS
diff --git a/content/common/DEPS b/content/common/DEPS
index 9e5bef74263ebf4208f061d3d4ce272d8e24c533..96a44b640275d79c16d5417da37e1c257f609fb1 100644
--- a/content/common/DEPS
+++ b/content/common/DEPS
@@ -23,6 +23,7 @@ include_rules = [
   "+third_party/WebKit/public/platform/WebScreenOrientation.h",
   "+third_party/WebKit/public/platform/WebScreenInfo.h",
   "+third_party/WebKit/public/platform/WebServiceWorkerError.h",
+  "+third_party/WebKit/public/platform/WebServiceWorkerResponse.h",

[Charlie Reis, 2014/03/05 21:00:34]

I see that there's already a DEPS exception for WebServiceWorkerError above, so
this is probably fine.  Can you explain why this is needed, though?

[falken, 2014/03/06 15:58:54]

Hmm.. it's not strictly needed but ServiceWorkerResponse is essentially just an
IPC-able version of WebServiceWorkerResponse so it seemed most convenient to
allow passing in WebServiceWorkerResponse to ServiceWorkerResponse's
constructor. The alternative would be to have a function somewhere else that
does the conversion, which I wouldn't mind doing.

WebServiceWorkerResponse is pretty simple, basically a bag of properties, but
not POD so it can't form an IPC message itself. If WebServiceWorkerResponse
changes, so should ServiceWorkerResponse, so the dependency exists regardless of
DEPS. WDYT?

Also, the DEPS change would require approval from a public/platform owner, so
+tkent.

[Charlie Reis, 2014/03/06 18:59:05]

+jam for his opinion.

[jam, 2014/03/06 21:22:43]

this doesn't pass the guideline in the common above, as it's not a strictly
enum/pod header. this wouldn't link in the chrome release build, since the
browser dll (which links in common) wouldn't link in blink

[falken, 2014/03/07 01:56:51]

OK, I removed the DEPS change.

Since just one place is doing the conversion now, I manually convert there. We
can move it to a separate function later if needed.

   "+third_party/WebKit/public/platform/WebStorageArea.h",
   "+third_party/WebKit/public/platform/WebString.h",
   "+third_party/WebKit/public/platform/linux/WebFontFamily.h",