Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 178343011: Support dispatching ServiceWorker FetchEvent and receiving response (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: plubming Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index c4cd44b6d71205ca68628a8e775e06874f08507a..afacd0487d8359b01a1ae90febbaec083c1c8e92 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -77,15 +77,15 @@ void HandleInstallFinished(const StatusCallback& callback,
void HandleFetchResponse(const ServiceWorkerVersion::FetchCallback& callback,
ServiceWorkerStatusCode status,
const IPC::Message& message) {
- Tuple1<ServiceWorkerFetchResponse> response;
+ Tuple2<ServiceWorkerFetchEventResult, ServiceWorkerResponse> params;
if (message.type() != ServiceWorkerHostMsg_FetchEventFinished::ID) {
NOTREACHED() << "Got unexpected response for FetchEvent: "
<< message.type();
- callback.Run(SERVICE_WORKER_ERROR_FAILED, response.a);
+ callback.Run(SERVICE_WORKER_ERROR_FAILED, params.a, params.b);
return;
}
- ServiceWorkerHostMsg_FetchEventFinished::Read(&message, &response);
- callback.Run(status, response.a);
+ ServiceWorkerHostMsg_FetchEventFinished::Read(&message, &params);
kinuko 2014/03/04 06:39:17 I think for 2+ parameters you can probably do this
falken 2014/03/05 03:35:41 Done.
+ callback.Run(status, params.a, params.b);
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698