Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1739)

Unified Diff: content/renderer/service_worker/service_worker_script_context.cc

Issue 178343011: Support dispatching ServiceWorker FetchEvent and receiving response (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use const for result on failure Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_script_context.cc
diff --git a/content/renderer/service_worker/service_worker_script_context.cc b/content/renderer/service_worker/service_worker_script_context.cc
index 6afe0036528cfde4c185125f27cc68775d643657..28cf0eaad9e44f644bed7c5cf47e71e41196015d 100644
--- a/content/renderer/service_worker/service_worker_script_context.cc
+++ b/content/renderer/service_worker/service_worker_script_context.cc
@@ -43,8 +43,9 @@ void ServiceWorkerScriptContext::DidHandleInstallEvent(int request_id) {
void ServiceWorkerScriptContext::DidHandleFetchEvent(
int request_id,
- const ServiceWorkerFetchResponse& response) {
- Send(request_id, ServiceWorkerHostMsg_FetchEventFinished(response));
+ ServiceWorkerFetchEventResult result,
+ const ServiceWorkerResponse& response) {
+ Send(request_id, ServiceWorkerHostMsg_FetchEventFinished(result, response));
}
void ServiceWorkerScriptContext::Send(int request_id,
@@ -59,10 +60,8 @@ void ServiceWorkerScriptContext::OnInstallEvent(
void ServiceWorkerScriptContext::OnFetchEvent(
const ServiceWorkerFetchRequest& request) {
- // TODO(falken): Dispatch the event to Blink and wait for the response from
- // respondWith. This is just a dummy response now.
- DidHandleFetchEvent(current_request_id_, ServiceWorkerFetchResponse(
- 200, "OK", "GET", std::map<std::string, std::string>()));
+ // TODO(falken): Pass in the request.
+ proxy_->dispatchFetchEvent(current_request_id_);
}
} // namespace content
« no previous file with comments | « content/renderer/service_worker/service_worker_script_context.h ('k') | content/test/data/service_worker/fetch_event.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698