Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: chrome/browser/chromeos/input_method/input_method_util.h

Issue 178343005: [IME] migrate the xkb ID to extension based xkb ID. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_util.h
diff --git a/chrome/browser/chromeos/input_method/input_method_util.h b/chrome/browser/chromeos/input_method/input_method_util.h
index a89ebd73398b0d1158d6c201275c503d03606177..eea2d9e586d496e5760b0195a5b003470946bee6 100644
--- a/chrome/browser/chromeos/input_method/input_method_util.h
+++ b/chrome/browser/chromeos/input_method/input_method_util.h
@@ -40,6 +40,9 @@ class InputMethodUtil {
// into Chrome's string ID, then pulls internationalized resource string from
// the resource bundle and returns it. These functions are not thread-safe.
// Non-UI threads are not allowed to call them.
+ // The english_string to should be a xkb id with "xkb:...:...:..." format.
+ // TODO(shuchen): this method should be removed when finish the wrapping of
+ // xkb to extension.
base::string16 TranslateString(const std::string& english_string) const;
// Converts an input method ID to a language code of the IME. Returns "Eng"
@@ -98,6 +101,14 @@ class InputMethodUtil {
// Returns empty string on error.
std::string GetLanguageDefaultInputMethodId(const std::string& language_code);
+ // Migrates the legacy xkb id to extension based xkb id.
+ // Returns true if the given input method id list is modified,
+ // returns false otherwise.
+ // TODO(shuchen): Remove this function after few milestones are passed.
+ // See: http://crbug.com/345604
+ bool MigrateXkbInputMethods(
+ std::vector<std::string>* input_method_ids);
+
// Updates the internal cache of hardware layouts.
void UpdateHardwareLayoutCache();

Powered by Google App Engine
This is Rietveld 408576698