Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: chromeos/ime/extension_ime_util.cc

Issue 178343005: [IME] migrate the xkb ID to extension based xkb ID. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/ime/extension_ime_util.cc
diff --git a/chromeos/ime/extension_ime_util.cc b/chromeos/ime/extension_ime_util.cc
index 7955e52536caae6569ca3c4a917fb6f66e25ab55..009ca5becb4ef6188d721d4391ec7fa4aef616ee 100644
--- a/chromeos/ime/extension_ime_util.cc
+++ b/chromeos/ime/extension_ime_util.cc
@@ -52,6 +52,13 @@ std::string GetExtensionIDFromInputMethodID(
return "";
}
+std::string GetInputMethodIDByKeyboardLayout(
+ const std::string& keyboard_layout_id) {
+ if (IsKeyboardLayoutExtension(keyboard_layout_id))
+ return keyboard_layout_id;
+ return kExtensionXkbIdPrefix + keyboard_layout_id;
Yuki 2014/02/27 02:40:33 I think it would be safer to DCHECK(keyboard_layou
Shu Chen 2014/02/27 03:12:12 The passed in keyboard_layout_id could be a new ex
+}
+
bool IsExtensionIME(const std::string& input_method_id) {
return StartsWithASCII(input_method_id,
kExtensionIMEPrefix,

Powered by Google App Engine
This is Rietveld 408576698