Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1783423004: Reenabling the disabled DestroyInSysCommandNCLButtonDownOnCaption and SysCommandMoveOnNCLButtonDown…

Created:
4 years, 9 months ago by ananta
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenabling the disabled DestroyInSysCommandNCLButtonDownOnCaption and SysCommandMoveOnNCLButtonDownOnCaptionAndMoveTest tests I was able to get these tests to fail if the mouse was anywhere in the vicinity of the window. The tests were calling the SetCursorPos API to avoid this. I guess it could happen if other tests on the bot via the shard end up moving the cursor. The fix is to peek out the messages pending in the queue after the window is visible. Generally Windows posts a WM_MOUSEMOVE message when a window becomes visible to allow it to set the cursor. Perhaps this is what is tripping us up. Removed the SetCursorPos call. BUG=592742

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M ui/views/widget/widget_unittest.cc View 5 chunks +5 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 3 (1 generated)
ananta
4 years, 9 months ago (2016-03-12 03:35:52 UTC) #2
sky
4 years, 9 months ago (2016-03-14 15:03:51 UTC) #3
On 2016/03/12 03:35:52, ananta wrote:

Seems better to move these to interactive ui tests so you know the test is run
without any other tests running at the same time.

Powered by Google App Engine
This is Rietveld 408576698