Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1783413002: Reenable WindowTreeClientUnittests (Closed)

Created:
4 years, 9 months ago by jonross
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable WindowTreeClientUnittests Add WindowTreeClientUnittest to build config. Address compilation changes. Disable tests that are currently failing. TEST=WindowTreeClientUnittest BUG=594181 Committed: https://crrev.com/3d42f4d131bc79b940169ea4cc5153c61530634e Cr-Commit-Position: refs/heads/master@{#380726}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M components/mus/ws/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/ws/window_tree_client_unittest.cc View 11 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jonross
Hi, Could you provide a review for this change? I'm bringing the test back online. ...
4 years, 9 months ago (2016-03-11 18:04:30 UTC) #2
sky
LGTM
4 years, 9 months ago (2016-03-11 19:13:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783413002/1
4 years, 9 months ago (2016-03-11 20:04:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 21:04:53 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 21:06:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d42f4d131bc79b940169ea4cc5153c61530634e
Cr-Commit-Position: refs/heads/master@{#380726}

Powered by Google App Engine
This is Rietveld 408576698