Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1783363006: [MD settings] remove Clear Browsing Data css file (Closed)

Created:
4 years, 9 months ago by dschuyler
Modified:
4 years, 9 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] remove Clear Browsing Data css file This CL removes an empty CSS file. BUG=532739 Committed: https://crrev.com/66982725a37a672c894ee360730148e2b6362c39 Cr-Commit-Position: refs/heads/master@{#380802}

Patch Set 1 #

Patch Set 2 : review change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
D chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.css View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dschuyler
4 years, 9 months ago (2016-03-11 23:17:25 UTC) #2
tommycli
lgtm thanks for doing this: Just double checking, this file isn't referenced anywhere right?
4 years, 9 months ago (2016-03-11 23:18:29 UTC) #3
tommycli
Okay revised message: lgtm assuming you remove it from these places: https://code.google.com/p/chromium/codesearch/#search/&q=clear_browsing_data_page.css&sq=package:chromium&type=cs
4 years, 9 months ago (2016-03-11 23:20:08 UTC) #4
dschuyler
Thanks!
4 years, 9 months ago (2016-03-11 23:21:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783363006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783363006/20001
4 years, 9 months ago (2016-03-12 00:07:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-12 00:27:29 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 00:29:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66982725a37a672c894ee360730148e2b6362c39
Cr-Commit-Position: refs/heads/master@{#380802}

Powered by Google App Engine
This is Rietveld 408576698