Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 178333005: Avoid calling Node::numberOfScopedHTMLStyleChildren() to check for existence (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
esprehn, adamk, eseidel
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis
Visibility:
Public.

Description

Avoid calling Node::numberOfScopedHTMLStyleChildren() to check for existence Avoid calling Node::numberOfScopedHTMLStyleChildren() to check for existence as we don't want to traverse all children merely to check for the existence of 1 child. Node::hasScopedHTMLStyleChild() can be used to check this instead as we have a dedicated flag for this. Also, don't unnecessarily traverse all children to set the HasScopedHTMLStyleChildFlag, and break early instead as soon as one child is found. R=adamk, eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167728

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M Source/core/dom/Node.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/dom/StyleSheetScopingNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
6 years, 10 months ago (2014-02-24 19:36:57 UTC) #1
esprehn
lgtm, but why do we need numberOfScopedHTMLStyleChildren at all?
6 years, 10 months ago (2014-02-24 19:43:43 UTC) #2
Inactive
On 2014/02/24 19:43:43, esprehn wrote: > lgtm, but why do we need numberOfScopedHTMLStyleChildren at all? ...
6 years, 10 months ago (2014-02-24 20:13:44 UTC) #3
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-24 20:19:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/178333005/1
6 years, 10 months ago (2014-02-24 20:19:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/178333005/1
6 years, 10 months ago (2014-02-25 01:05:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/178333005/1
6 years, 10 months ago (2014-02-25 05:16:53 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 06:36:25 UTC) #8
Message was sent while issue was closed.
Change committed as 167728

Powered by Google App Engine
This is Rietveld 408576698