Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/heap-snapshot-generator.cc

Issue 17833002: Remove obsolete unchecked accessors in JSFunction. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/frames.cc ('k') | src/mark-compact.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1030 matching lines...) Expand 10 before | Expand all | Expand 10 after
1041 TagObject(js_fun->literals_or_bindings(), 1041 TagObject(js_fun->literals_or_bindings(),
1042 bound ? "(function bindings)" : "(function literals)"); 1042 bound ? "(function bindings)" : "(function literals)");
1043 SetInternalReference(js_fun, entry, 1043 SetInternalReference(js_fun, entry,
1044 bound ? "bindings" : "literals", 1044 bound ? "bindings" : "literals",
1045 js_fun->literals_or_bindings(), 1045 js_fun->literals_or_bindings(),
1046 JSFunction::kLiteralsOffset); 1046 JSFunction::kLiteralsOffset);
1047 TagObject(shared_info, "(shared function info)"); 1047 TagObject(shared_info, "(shared function info)");
1048 SetInternalReference(js_fun, entry, 1048 SetInternalReference(js_fun, entry,
1049 "shared", shared_info, 1049 "shared", shared_info,
1050 JSFunction::kSharedFunctionInfoOffset); 1050 JSFunction::kSharedFunctionInfoOffset);
1051 TagObject(js_fun->unchecked_context(), "(context)"); 1051 TagObject(js_fun->context(), "(context)");
1052 SetInternalReference(js_fun, entry, 1052 SetInternalReference(js_fun, entry,
1053 "context", js_fun->unchecked_context(), 1053 "context", js_fun->context(),
1054 JSFunction::kContextOffset); 1054 JSFunction::kContextOffset);
1055 for (int i = JSFunction::kNonWeakFieldsEndOffset; 1055 for (int i = JSFunction::kNonWeakFieldsEndOffset;
1056 i < JSFunction::kSize; 1056 i < JSFunction::kSize;
1057 i += kPointerSize) { 1057 i += kPointerSize) {
1058 SetWeakReference(js_fun, entry, i, *HeapObject::RawField(js_fun, i), i); 1058 SetWeakReference(js_fun, entry, i, *HeapObject::RawField(js_fun, i), i);
1059 } 1059 }
1060 } else if (obj->IsGlobalObject()) { 1060 } else if (obj->IsGlobalObject()) {
1061 GlobalObject* global_obj = GlobalObject::cast(obj); 1061 GlobalObject* global_obj = GlobalObject::cast(obj);
1062 SetInternalReference(global_obj, entry, 1062 SetInternalReference(global_obj, entry,
1063 "builtins", global_obj->builtins(), 1063 "builtins", global_obj->builtins(),
(...skipping 1604 matching lines...) Expand 10 before | Expand all | Expand 10 after
2668 2668
2669 2669
2670 void HeapSnapshotJSONSerializer::SortHashMap( 2670 void HeapSnapshotJSONSerializer::SortHashMap(
2671 HashMap* map, List<HashMap::Entry*>* sorted_entries) { 2671 HashMap* map, List<HashMap::Entry*>* sorted_entries) {
2672 for (HashMap::Entry* p = map->Start(); p != NULL; p = map->Next(p)) 2672 for (HashMap::Entry* p = map->Start(); p != NULL; p = map->Next(p))
2673 sorted_entries->Add(p); 2673 sorted_entries->Add(p);
2674 sorted_entries->Sort(SortUsingEntryValue); 2674 sorted_entries->Sort(SortUsingEntryValue);
2675 } 2675 }
2676 2676
2677 } } // namespace v8::internal 2677 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/frames.cc ('k') | src/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698