Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1783283003: [heap] Remove unused flag prohibiting local slot buffer entries (Closed)

Created:
4 years, 9 months ago by Michael Lippautz
Modified:
4 years, 9 months ago
Reviewers:
ulan, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove unused flag prohibiting local slot buffer entries This is a fix that removes a left over from https://crrev.com/4566531c6e593ae8bffc2ef96f82c91d15a68acf With this flag set to false still present, we would race on inserting in the local old-to-new remembered set. R=ulan@chormium.org BUG=chromium:524425 LOG=N Committed: https://crrev.com/b154e480008b64c3794202f68bf8b01e801aeaa7 Cr-Commit-Position: refs/heads/master@{#34728}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M src/heap/mark-compact.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Lippautz
4 years, 9 months ago (2016-03-11 14:54:06 UTC) #1
Michael Lippautz
4 years, 9 months ago (2016-03-11 14:54:06 UTC) #2
ulan
lgtm, good catch!
4 years, 9 months ago (2016-03-11 14:55:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783283003/20001
4 years, 9 months ago (2016-03-11 14:56:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-11 15:23:12 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 15:24:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b154e480008b64c3794202f68bf8b01e801aeaa7
Cr-Commit-Position: refs/heads/master@{#34728}

Powered by Google App Engine
This is Rietveld 408576698