Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Issue 1783233004: Disabling power.touch_ad_cases to turn Android One green. (Closed)

Created:
4 years, 9 months ago by picksi
Modified:
4 years, 9 months ago
Reviewers:
sullivan, sullivan1
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling power.touch_ad_cases to turn Android One green. BUG=593973 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/db5df850029cd0578e9ec391fd3de28eb5ba5c1c Cr-Commit-Position: refs/heads/master@{#380672}

Patch Set 1 #

Patch Set 2 : Disabling test only on Svelte devices #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/perf/benchmarks/power.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
picksi
Hi Annie, Can you check this and LGTM it if it looks good. I'm disabling ...
4 years, 9 months ago (2016-03-11 14:29:57 UTC) #3
sullivan
It looks like this is only broken on Android One? Can you change it to ...
4 years, 9 months ago (2016-03-11 14:36:37 UTC) #4
picksi
PTAL!
4 years, 9 months ago (2016-03-11 14:45:52 UTC) #5
sullivan
lgtm Thanks!
4 years, 9 months ago (2016-03-11 14:46:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783233004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783233004/20001
4 years, 9 months ago (2016-03-11 14:46:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_retina_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_cq/builds/36)
4 years, 9 months ago (2016-03-11 15:36:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783233004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783233004/20001
4 years, 9 months ago (2016-03-11 16:14:36 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-11 18:18:26 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 18:20:11 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db5df850029cd0578e9ec391fd3de28eb5ba5c1c
Cr-Commit-Position: refs/heads/master@{#380672}

Powered by Google App Engine
This is Rietveld 408576698