Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1783133002: Valgrind: Exclude a couple tests that run very slowly. (Closed)

Created:
4 years, 9 months ago by Lei Zhang
Modified:
4 years, 9 months ago
CC:
bruening+watch_chromium.org, chrishall, chromium-reviews, glider+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Valgrind: Exclude a couple tests that run very slowly. Committed: https://crrev.com/d4793d5841f84175a0d069391fd612f9cc3f1345 Cr-Commit-Position: refs/heads/master@{#381565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/media_unittests.gtest.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/net_unittests.gtest.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
Can we disable these 2 tests under Valgrind and trade a bit less coverage for ...
4 years, 9 months ago (2016-03-11 02:06:33 UTC) #2
DaleCurtis
lgtm
4 years, 9 months ago (2016-03-11 02:07:43 UTC) #3
Eran Messeri
lgtm for net_unittests changes (the test excluded is slow in general, as it is CPU ...
4 years, 9 months ago (2016-03-11 13:19:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1783133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1783133002/1
4 years, 9 months ago (2016-03-16 21:19:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 22:17:57 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 22:19:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4793d5841f84175a0d069391fd612f9cc3f1345
Cr-Commit-Position: refs/heads/master@{#381565}

Powered by Google App Engine
This is Rietveld 408576698