third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py - Issue 1783073002: Run auto-formatter on files in webkitpy/layout_tests/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

Issue 1783073002: Run auto-formatter on files in webkitpy/layout_tests/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ran yapf -i --style '{based_on_style: pep8, column_limit: 132}' then did manual fix-up Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

index b082338187e0a38a6c9e5455fd31c13d3a490f71..b62d93309edba61d9433722f45ab743100600044 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

@@ -34,7 +34,6 @@ import Queue

from webkitpy.common.webkit_finder import WebKitFinder

from webkitpy.layout_tests.breakpad.dump_reader import DumpReader

_log = logging.getLogger(__name__)

@@ -95,10 +94,7 @@ class DumpReaderMultipart(DumpReader):

if self._breakpad_tools_available != None:

return self._breakpad_tools_available

- REQUIRED_BREAKPAD_TOOLS = [

- 'dump_syms',

- 'minidump_stackwalk',

- ]

+ REQUIRED_BREAKPAD_TOOLS = ['dump_syms', 'minidump_stackwalk', ]

result = True

for binary in REQUIRED_BREAKPAD_TOOLS:

full_path = self._host.filesystem.join(self._build_dir, binary)

@@ -119,7 +115,8 @@ class DumpReaderMultipart(DumpReader):

return self._host.filesystem.join(self._build_dir, "minidump_stackwalk")

def _path_to_generate_breakpad_symbols(self):

- return self._webkit_finder.path_from_chromium_base("components", "crash", "content", "tools", "generate_breakpad_symbols.py")

+ return self._webkit_finder.path_from_chromium_base("components", "crash", "content", "tools",

+ "generate_breakpad_symbols.py")

def _symbols_dir(self):

return self._host.filesystem.join(self._build_dir, 'content_shell.syms')

@@ -131,7 +128,7 @@ class DumpReaderMultipart(DumpReader):

_log.debug("Generating breakpad symbols")

queue = Queue.Queue()

- thread = threading.Thread(target=_symbolize_keepalive, args=(queue,))

+ thread = threading.Thread(target=_symbolize_keepalive, args=(queue, ))

thread.start()

try:

for binary in self._binaries_to_symbolize():